[ 
https://issues.apache.org/jira/browse/TWILL-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15836910#comment-15836910
 ] 

ASF GitHub Bot commented on TWILL-208:
--------------------------------------

Github user poornachandra commented on a diff in the pull request:

    https://github.com/apache/twill/pull/26#discussion_r97683616
  
    --- Diff: 
twill-common/src/main/java/org/apache/twill/filesystem/LocalLocation.java ---
    @@ -251,6 +251,34 @@ public boolean mkdirs() throws IOException {
         return file.mkdirs();
       }
     
    +  @Override
    +  public boolean mkdirs(String permission) throws IOException {
    --- End diff --
    
    Should we use  
[Files.createDirectories](http://docs.oracle.com/javase/7/docs/api/java/nio/file/Files.html#createDirectories(java.nio.file.Path,%20java.nio.file.attribute.FileAttribute...))
 since it also takes permissions?


> Location should have a way to set permissions when creating directories
> -----------------------------------------------------------------------
>
>                 Key: TWILL-208
>                 URL: https://issues.apache.org/jira/browse/TWILL-208
>             Project: Apache Twill
>          Issue Type: Bug
>            Reporter: Andreas Neumann
>            Assignee: Andreas Neumann
>             Fix For: 0.10.0
>
>
> That is, we need to introduce a method
> {code}
> boolean mkdirs(String permissions);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to