[
https://issues.apache.org/jira/browse/TWILL-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15836965#comment-15836965
]
ASF GitHub Bot commented on TWILL-208:
--------------------------------------
Github user anew commented on a diff in the pull request:
https://github.com/apache/twill/pull/26#discussion_r97689666
--- Diff:
twill-common/src/main/java/org/apache/twill/filesystem/Location.java ---
@@ -207,6 +207,21 @@
boolean mkdirs() throws IOException;
/**
+ * Creates the directory named by this abstract pathname, including any
necessary
+ * but nonexistent parent directories.
+ *
+ * @param permission A permission string. It has to be either a three
digit or a nine character string.
+ * For the three digit string, it is similar to the
UNIX permission numeric representation.
+ * The first digit is the permission for owner, second
digit is the permission for group and
+ * the third digit is the permission for all.
+ * For the nine character string, it uses the format
as specified by the
+ * {@link PosixFilePermissions#fromString(String)}
method.
+ *
+ * @return true if and only if the renaming succeeded; false otherwise
--- End diff --
good catch. I actually did not want that line :)
> Location should have a way to set permissions when creating directories
> -----------------------------------------------------------------------
>
> Key: TWILL-208
> URL: https://issues.apache.org/jira/browse/TWILL-208
> Project: Apache Twill
> Issue Type: Bug
> Reporter: Andreas Neumann
> Assignee: Andreas Neumann
> Fix For: 0.10.0
>
>
> That is, we need to introduce a method
> {code}
> boolean mkdirs(String permissions);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
