[
https://issues.apache.org/jira/browse/TWILL-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15836970#comment-15836970
]
ASF GitHub Bot commented on TWILL-208:
--------------------------------------
Github user anew commented on a diff in the pull request:
https://github.com/apache/twill/pull/26#discussion_r97689935
--- Diff:
twill-common/src/main/java/org/apache/twill/filesystem/LocalLocation.java ---
@@ -98,8 +98,8 @@ public OutputStream getOutputStream() throws IOException {
@Override
public OutputStream getOutputStream(String permission) throws
IOException {
- ensureDirectory(file.getParentFile());
Set<PosixFilePermission> permissions = parsePermissions(permission);
+ ensureDirectory(file.getParentFile(), permissions);
--- End diff --
yes, the intention of permissions is that others get access through, for
example, group permission. So if I create the file with 700 but the directories
are created with the default umask of 750, then that is not great. Even worse,
if I create the file with 755, and the directories are created with 750, then
world cannot access the file despite the intention.
> Location should have a way to set permissions when creating directories
> -----------------------------------------------------------------------
>
> Key: TWILL-208
> URL: https://issues.apache.org/jira/browse/TWILL-208
> Project: Apache Twill
> Issue Type: Bug
> Reporter: Andreas Neumann
> Assignee: Andreas Neumann
> Fix For: 0.10.0
>
>
> That is, we need to introduce a method
> {code}
> boolean mkdirs(String permissions);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
