[ 
https://issues.apache.org/jira/browse/TWILL-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838571#comment-15838571
 ] 

ASF GitHub Bot commented on TWILL-208:
--------------------------------------

Github user gokulavasan commented on a diff in the pull request:

    https://github.com/apache/twill/pull/26#discussion_r97876853
  
    --- Diff: 
twill-yarn/src/test/java/org/apache/twill/filesystem/HDFSLocationTest.java ---
    @@ -47,4 +52,14 @@ public static void finish() {
       protected LocationFactory createLocationFactory(String pathBase) throws 
Exception {
         return new HDFSLocationFactory(dfsCluster.getFileSystem(), pathBase);
       }
    +
    +  // TODO (TWILL-209): figure out how to make MiniDFSCluster enforce 
permissions
    +  @Ignore
    +  @Test(expected = Exception.class)
    +  public void testPermissions() throws IOException {
    +    // create a directory that does not permit anything
    +    dfsCluster.getFileSystem().mkdir(new Path("/a"), 
FsPermission.valueOf("----------"));
    --- End diff --
    
    Oh ok, missed the Ignore annotation. It might be good to try and catch and 
have an Assert.fail at the end of the try block for the new tests that we are 
adding.


> Location should have a way to set permissions when creating directories
> -----------------------------------------------------------------------
>
>                 Key: TWILL-208
>                 URL: https://issues.apache.org/jira/browse/TWILL-208
>             Project: Apache Twill
>          Issue Type: Bug
>            Reporter: Andreas Neumann
>            Assignee: Andreas Neumann
>             Fix For: 0.10.0
>
>
> That is, we need to introduce a method
> {code}
> boolean mkdirs(String permissions);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to