Github user anew commented on a diff in the pull request:
https://github.com/apache/twill/pull/26#discussion_r97689666
--- Diff:
twill-common/src/main/java/org/apache/twill/filesystem/Location.java ---
@@ -207,6 +207,21 @@
boolean mkdirs() throws IOException;
/**
+ * Creates the directory named by this abstract pathname, including any
necessary
+ * but nonexistent parent directories.
+ *
+ * @param permission A permission string. It has to be either a three
digit or a nine character string.
+ * For the three digit string, it is similar to the
UNIX permission numeric representation.
+ * The first digit is the permission for owner, second
digit is the permission for group and
+ * the third digit is the permission for all.
+ * For the nine character string, it uses the format
as specified by the
+ * {@link PosixFilePermissions#fromString(String)}
method.
+ *
+ * @return true if and only if the renaming succeeded; false otherwise
--- End diff --
good catch. I actually did not want that line :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
