Github user gokulavasan commented on a diff in the pull request:
https://github.com/apache/twill/pull/26#discussion_r97885713
--- Diff:
twill-yarn/src/test/java/org/apache/twill/filesystem/HDFSLocationTest.java ---
@@ -55,11 +55,19 @@ protected LocationFactory createLocationFactory(String
pathBase) throws Exceptio
// TODO (TWILL-209): figure out how to make MiniDFSCluster enforce
permissions
@Ignore
- @Test(expected = Exception.class)
public void testPermissions() throws IOException {
// create a directory that does not permit anything
dfsCluster.getFileSystem().mkdir(new Path("/a"),
FsPermission.valueOf("----------"));
- // creating a subdir should fail because even the owner has no write
permission
- dfsCluster.getFileSystem().mkdir(new Path("/a/b"),
FsPermission.valueOf("----------"));
+ boolean succeeded = false;
+ try {
+ // creating a subdir should fail because even the owner has no write
permission
+ dfsCluster.getFileSystem().mkdir(new Path("/a/b"),
FsPermission.valueOf("----------"));
+ succeeded = true;
+ } catch (Exception e) {
+ // expected; TODO: figure out which exception should the expected
here, it's not documented
+ }
+ if (succeeded) {
--- End diff --
No it won't I think. Since Assert.fail throws AssertionError which doesn't
extend Exception?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
