Github user gokulavasan commented on a diff in the pull request:

    https://github.com/apache/twill/pull/26#discussion_r97876853
  
    --- Diff: 
twill-yarn/src/test/java/org/apache/twill/filesystem/HDFSLocationTest.java ---
    @@ -47,4 +52,14 @@ public static void finish() {
       protected LocationFactory createLocationFactory(String pathBase) throws 
Exception {
         return new HDFSLocationFactory(dfsCluster.getFileSystem(), pathBase);
       }
    +
    +  // TODO (TWILL-209): figure out how to make MiniDFSCluster enforce 
permissions
    +  @Ignore
    +  @Test(expected = Exception.class)
    +  public void testPermissions() throws IOException {
    +    // create a directory that does not permit anything
    +    dfsCluster.getFileSystem().mkdir(new Path("/a"), 
FsPermission.valueOf("----------"));
    --- End diff --
    
    Oh ok, missed the Ignore annotation. It might be good to try and catch and 
have an Assert.fail at the end of the try block for the new tests that we are 
adding.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to