Github user anew commented on a diff in the pull request:
https://github.com/apache/twill/pull/26#discussion_r97689935
--- Diff:
twill-common/src/main/java/org/apache/twill/filesystem/LocalLocation.java ---
@@ -98,8 +98,8 @@ public OutputStream getOutputStream() throws IOException {
@Override
public OutputStream getOutputStream(String permission) throws
IOException {
- ensureDirectory(file.getParentFile());
Set<PosixFilePermission> permissions = parsePermissions(permission);
+ ensureDirectory(file.getParentFile(), permissions);
--- End diff --
yes, the intention of permissions is that others get access through, for
example, group permission. So if I create the file with 700 but the directories
are created with the default umask of 750, then that is not great. Even worse,
if I create the file with 755, and the directories are created with 750, then
world cannot access the file despite the intention.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
