Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/twill/pull/33#discussion_r101699224
  
    --- Diff: twill-api/src/main/java/org/apache/twill/api/Configs.java ---
    @@ -34,6 +36,11 @@
         public static final String JAVA_RESERVED_MEMORY_MB = 
"twill.java.reserved.memory.mb";
     
         /**
    +     * Configurable ratio between Heap and Reserved Memory
    +     */
    +    public static final String HEAP_RESERVED_MIN_RATIO_CONFIG = 
"twill.java.reserved.memory.ratio";
    --- End diff --
    
    Also, I think the config key should be `twill.java.min.heap.memory.ratio`, 
as it is the minimum ratio of heap memory.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to