Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/33#discussion_r101698978
--- Diff: twill-api/src/main/java/org/apache/twill/api/Configs.java ---
@@ -75,6 +82,7 @@ private Keys() {
*/
public static final int JAVA_RESERVED_MEMORY_MB = 200;
+ public static final double HEAP_RESERVED_MIN_RATIO_DEFAULT =
Constants.HEAP_MIN_RATIO;
--- End diff --
Inside the `Defaults` class, no need to repeat the variable with `DEFAULT`.
Just name it the same as the config key constant.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
