Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/twill/pull/33#discussion_r101699432
  
    --- Diff: 
twill-core/src/main/java/org/apache/twill/internal/TwillRuntimeSpecification.java
 ---
    @@ -41,11 +41,23 @@
       private final String rmSchedulerAddr;
       private final Map<String, Map<String, String>> logLevels;
       private final Map<String, Integer> maxRetries;
    +  private Double heapToReserveRatio;
    --- End diff --
    
    Shouldn't allow null. This is an internal class, you can simply require the 
caller to pass in valid value.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to