Hi Pushpalanka, Was confused in the PR procedure, and figured that I forgot to initialize the github repo as you have mentioned in a previous message. So the new location of the codebase is at [1] Over the weekend, I'll fix any remaining issues and send the PR For now I have used the wso2-codestyle given by Omindu and reformatted the code and added Findbug as well.
Thank You Manujith [1] https://github.com/ManZzup/identity-framework/tree/master/components/entitlement/org.wso2.carbon.identity.entitlement.endpoint On Wed, Jun 8, 2016 at 11:35 AM, Pushpalanka Jayawardhana <la...@wso2.com> wrote: > > > On Tue, Jun 7, 2016 at 11:01 AM, Manujith Pallewatte < > manujith...@gmail.com> wrote: > >> Hi all, >> >> Code is almost all refracted (apart from the part where authenticators >> are hard coded) and it' is available at [1] >> I have attached a readme so everyone can help with testing it. But >> there's still an issue remaining to debug with the *entitled-attribs *service >> call, that came up in preliminary testing by Omindu. >> >> Thank You Omindu, I will use the formatting configs and format the code >> asap. For now i added a gitignore as in the sample you sent, but I left >> *target >> *directory intact so that i can share the war file through the repo. >> >> Also for the PR, to which repo should I send the PR for? Or shall I wait >> for further testing of the code so that we can minimize any bugs? >> > If code refactoring, formatting, cleanup are done, you have run Findbug > plugin(This is a plugin that can integrate to IDE. If you already haven't > try it.) and fixed any issues reported against code and functionality is > working, we are OK to review the code. You can further test the code and > fix the bugs while integrating any review comments we put on the PR. > > "Please share the code progress via Github, once you are satisfied with > refactoring. > Please fork [1] to your private repo, and at location [2], you may have a > new component named 'org.wso2.carbon.identity.entitlement.endpoint' where > the implementation can reside. > > [1] - https://github.com/wso2/carbon-identity-framework > [2] - > https://github.com/wso2/carbon-identity-framework/tree/master/components/entitlement > " > >> >> [1] https://github.com/ManZzup/identity-entitlement-endpoint >> >> Thank You, >> Best Regards >> Manujith >> >> On Tue, Jun 7, 2016 at 10:30 AM, Omindu Rathnaweera <omi...@wso2.com> >> wrote: >> >>> Adding a .gitignore to the repo will be the easiest way to keep the >>> unwanted files away from the repo. See [1]. >>> >>> [1] - >>> https://github.com/wso2/carbon-identity-framework/blob/master/.gitignore >>> >>> Regards, >>> Omindu >>> >>> On Tue, Jun 7, 2016 at 10:26 AM, Pushpalanka Jayawardhana < >>> la...@wso2.com> wrote: >>> >>>> Hi Manujith, >>>> >>>> The IDE specific files(.iml) or code can be removed from the repository. >>>> Once the code refactoring is done and code is cleaned please feel free >>>> to send the PR. Then we can easily comment on the code. >>>> >>>> Thanks, >>>> Pushpalanka >>>> >>>> >>>> On Tue, Jun 7, 2016 at 10:12 AM, Omindu Rathnaweera <omi...@wso2.com> >>>> wrote: >>>> >>>>> Hi Manujith, >>>>> >>>>> Better if you can clean up the unnecessary code and do some code >>>>> refactoring. We can do another round of testing once you fix the issues I >>>>> have mention. You can use the attached Idea Code Formatting Template [1]. >>>>> >>>>> To apply the template, follow the steps below. >>>>> >>>>> 1. In IDEA settings, goto Editor -> Code Style. >>>>> 2. Click 'Manage' then 'Save As...' an existing scheme with the name >>>>> 'wso2-codestyle' and Close the IDE. >>>>> 3. Goto ~/.IntelliJIdea16/config/codestyles directory and replace the >>>>> 'wso2-codestyle.xml' file with the attached one. >>>>> >>>>> [1] - >>>>> https://drive.google.com/file/d/0BzRDbfbIaYjCSzhGRUR1aGdlTXM/view?usp=sharing >>>>> >>>>> Regards, >>>>> Omindu. >>>>> >>>>> >>>>> On Mon, Jun 6, 2016 at 8:29 AM, Manujith Pallewatte < >>>>> manujith...@gmail.com> wrote: >>>>> >>>>>> Hi all, >>>>>> >>>>>> After a bit of refactoring I added the code to [1]. Please feel free >>>>>> to check the source and give your ideas to improve, specially on the >>>>>> service related code. All the service related code is available at [2] >>>>>> >>>>>> Also Omindu tested the initial war file and reported several issues >>>>>> with it, hoping to debug those within the week >>>>>> >>>>>> >>>>>> [1] https://github.com/ManZzup/identity-entitlement-endpoint >>>>>> [2] >>>>>> https://github.com/ManZzup/identity-entitlement-endpoint/blob/master/src/main/java/org/wso2/carbon/identity/entitlement/provider/resources/DecisionResource.java >>>>>> >>>>>> On Wed, Jun 1, 2016 at 10:21 AM, Pushpalanka Jayawardhana < >>>>>> la...@wso2.com> wrote: >>>>>> >>>>>>> Hi Manujith, >>>>>>> >>>>>>> Please share the code progress via Github, once you are satisfied >>>>>>> with refactoring. >>>>>>> Please fork [1] to your private repo, and at location [2], you may >>>>>>> have a new component named >>>>>>> 'org.wso2.carbon.identity.entitlement.endpoint' >>>>>>> where the implementation can reside. >>>>>>> >>>>>>> [1] - https://github.com/wso2/carbon-identity-framework >>>>>>> [2] - >>>>>>> https://github.com/wso2/carbon-identity-framework/tree/master/components/entitlement >>>>>>> >>>>>>> Thanks, >>>>>>> Pushpalanka >>>>>>> >>>>>>> On Wed, Jun 1, 2016 at 10:00 AM, Manujith Pallewatte < >>>>>>> manujith...@gmail.com> wrote: >>>>>>> >>>>>>>> Hi all, >>>>>>>> >>>>>>>> So I have roughly finished up the following 5 services in REST >>>>>>>> getDecision >>>>>>>> getDecisionByAttibutes >>>>>>>> getBooleanDecision >>>>>>>> getEntitledAttributes >>>>>>>> getAllEntitlements >>>>>>>> >>>>>>>> The service is packed to a war file deployable to IS 5.2.0 >>>>>>>> It's still in primary testing, so once it's confirmed working it >>>>>>>> will be released to the community to get their ideas >>>>>>>> the URIs and methods should be adjusted with the community >>>>>>>> suggestions >>>>>>>> >>>>>>>> Hoping to release the war file in coming week as well as the code. >>>>>>>> The code have to be refracted first. >>>>>>>> >>>>>>>> Thank You >>>>>>>> >>>>>>>> On Mon, May 23, 2016 at 2:05 PM, Manujith Pallewatte < >>>>>>>> manujith...@gmail.com> wrote: >>>>>>>> >>>>>>>>> Hi all, >>>>>>>>> >>>>>>>>> To update on the progress so far, after having a chat with >>>>>>>>> Pushpalanka, I started with the project code. Basic setups are done. >>>>>>>>> Necessary entry points for the service was identified and now I'm >>>>>>>>> familiar with the process of deploying the REST service as a Web app >>>>>>>>> to the >>>>>>>>> IS. >>>>>>>>> >>>>>>>>> Right now, the getDecision method is implemented in a RESTful >>>>>>>>> manner, using Apache cxf (following the guidelines of SCIM >>>>>>>>> implementation >>>>>>>>> as suggested by Pushpalanka and Omindu). The implementation works, >>>>>>>>> yet it's >>>>>>>>> only a test implementation. >>>>>>>>> >>>>>>>>> We are expecting to consult the community on the actual >>>>>>>>> implementation of the service, focusing on points like >>>>>>>>> 1) End point URLs >>>>>>>>> 2) Resource identification >>>>>>>>> 3) Service method definitions >>>>>>>>> >>>>>>>>> At the moment I'm struggling with implementations of some methods >>>>>>>>> using the current CXF version, hoping to resolve it ASAP. >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Manujith >>>>>>>>> >>>>>>>>> On Mon, May 16, 2016 at 11:18 AM, Pushpalanka Jayawardhana < >>>>>>>>> la...@wso2.com> wrote: >>>>>>>>> >>>>>>>>>> Hi Manujith, >>>>>>>>>> >>>>>>>>>> Good progress in getting familiar with the environment. >>>>>>>>>> So let's try to start with the scope of the project too. >>>>>>>>>> >>>>>>>>>> Since we are to work on implementing REST service, it is better >>>>>>>>>> to go through WSO2 guidelines for REST service implementation. >>>>>>>>>> Please find >>>>>>>>>> the white paper at[1] and the relevant discussion can be found at >>>>>>>>>> architecture mailing list under "REST API Guidelines". Then we can >>>>>>>>>> work on >>>>>>>>>> defining the API definition for the endpoint. >>>>>>>>>> >>>>>>>>>> You can also have a look at the existing WSO2 REST implementation >>>>>>>>>> to capture the followed patterns referring the SCIM[2] and OAuth >>>>>>>>>> endpoints[3]. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> [1] - >>>>>>>>>> http://wso2.com/whitepapers/wso2-rest-apis-design-guidelines/ >>>>>>>>>> [2] - >>>>>>>>>> https://github.com/wso2-extensions/identity-inbound-provisioning-scim/tree/master/components/org.wso2.carbon.identity.scim.provider >>>>>>>>>> [3] - >>>>>>>>>> https://github.com/wso2-extensions/identity-inbound-auth-oauth/tree/master/components/org.wso2.carbon.identity.oauth.endpoint >>>>>>>>>> >>>>>>>>>> Thanks, >>>>>>>>>> Pushpalanka >>>>>>>>>> >>>>>>>>>> On Wed, May 11, 2016 at 3:23 PM, Manujith Pallewatte < >>>>>>>>>> manujith...@gmail.com> wrote: >>>>>>>>>> >>>>>>>>>>> Hi Pushpalanka, >>>>>>>>>>> >>>>>>>>>>> I managed to setup the development environment and build all the >>>>>>>>>>> sources (thanks to Omindu :)) >>>>>>>>>>> Then I made the PEP client using the entitlement stubs as you >>>>>>>>>>> have mentioned in a previous thread. It's working in an accepted >>>>>>>>>>> state. But >>>>>>>>>>> I encountered some questions during the process, so I'm currently >>>>>>>>>>> building >>>>>>>>>>> a doc with all the questions so I can document them and their >>>>>>>>>>> answers for >>>>>>>>>>> future reference. >>>>>>>>>>> Other than that I'm trying to write different policies using >>>>>>>>>>> XACML >>>>>>>>>>> >>>>>>>>>>> Also please let me know of any other steps i can follow to get >>>>>>>>>>> familiar with the components, specially the code since I'm only >>>>>>>>>>> focusing on >>>>>>>>>>> Entitlement service right now >>>>>>>>>>> >>>>>>>>>>> Thank You >>>>>>>>>>> Manujith >>>>>>>>>>> -- >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> [image: Manujith Pallewatte on about.me] >>>>>>>>>>> >>>>>>>>>>> Manujith Pallewatte >>>>>>>>>>> about.me/manzzup >>>>>>>>>>> <http://about.me/manzzup> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Pushpalanka. >>>>>>>>>> -- >>>>>>>>>> Pushpalanka Jayawardhana, B.Sc.Eng.(Hons). >>>>>>>>>> Senior Software Engineer, WSO2 Lanka (pvt) Ltd; wso2.com/ >>>>>>>>>> Mobile: +94779716248 >>>>>>>>>> Blog: pushpalankajaya.blogspot.com/ | LinkedIn: >>>>>>>>>> lk.linkedin.com/in/pushpalanka/ | Twitter: @pushpalanka >>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> [image: Manujith Pallewatte on about.me] >>>>>>>>> >>>>>>>>> Manujith Pallewatte >>>>>>>>> about.me/manzzup >>>>>>>>> <http://about.me/manzzup> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> [image: Manujith Pallewatte on about.me] >>>>>>>> >>>>>>>> Manujith Pallewatte >>>>>>>> about.me/manzzup >>>>>>>> <http://about.me/manzzup> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Pushpalanka. >>>>>>> -- >>>>>>> Pushpalanka Jayawardhana, B.Sc.Eng.(Hons). >>>>>>> Senior Software Engineer, WSO2 Lanka (pvt) Ltd; wso2.com/ >>>>>>> Mobile: +94779716248 >>>>>>> Blog: pushpalankajaya.blogspot.com/ | LinkedIn: >>>>>>> lk.linkedin.com/in/pushpalanka/ | Twitter: @pushpalanka >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> >>>>>> >>>>>> >>>>>> [image: Manujith Pallewatte on about.me] >>>>>> >>>>>> Manujith Pallewatte >>>>>> about.me/manzzup >>>>>> <http://about.me/manzzup> >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Omindu Rathnaweera >>>>> Software Engineer, WSO2 Inc. >>>>> Mobile: +94 771 197 211 >>>>> >>>> >>>> >>>> >>>> -- >>>> Pushpalanka. >>>> -- >>>> Pushpalanka Jayawardhana, B.Sc.Eng.(Hons). >>>> Senior Software Engineer, WSO2 Lanka (pvt) Ltd; wso2.com/ >>>> Mobile: +94779716248 >>>> Blog: pushpalankajaya.blogspot.com/ | LinkedIn: >>>> lk.linkedin.com/in/pushpalanka/ | Twitter: @pushpalanka >>>> >>>> >>> >>> >>> -- >>> Omindu Rathnaweera >>> Software Engineer, WSO2 Inc. >>> Mobile: +94 771 197 211 >>> >> >> >> >> -- >> >> >> >> [image: Manujith Pallewatte on about.me] >> >> Manujith Pallewatte >> about.me/manzzup >> <http://about.me/manzzup> >> > > > > -- > Pushpalanka. > -- > Pushpalanka Jayawardhana, B.Sc.Eng.(Hons). > Senior Software Engineer, WSO2 Lanka (pvt) Ltd; wso2.com/ > Mobile: +94779716248 > Blog: pushpalankajaya.blogspot.com/ | LinkedIn: > lk.linkedin.com/in/pushpalanka/ | Twitter: @pushpalanka > > -- [image: Manujith Pallewatte on about.me] Manujith Pallewatte about.me/manzzup <http://about.me/manzzup>
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
