Hi Suho and all, The problem has been identified and fixed with the new commit [1]. According to this commit, the following changes have been done:
(1) No need to use arbitrary_ prefix anywhere. (2) The publisher will first check for payload data, if not available it will check for the arbitrary data. Therefore use the arbitrary data map keys as they are. [2][3] (3) Arbitrary data can be used in dynamic properties. [3] [1] https://github.com/wso2/carbon-analytics-common/commit/f1d5cafe92e9b71b884a9a4838e2cc446cf83685 [2] https://github.com/wso2/carbon-analytics-common/blob/master/components/event-publisher/org.wso2.carbon.event.publisher.core/src/main/java/org/wso2/carbon/event/publisher/core/internal/type/text/TextOutputMapper.java#L168 [3] https://github.com/wso2/carbon-analytics-common/blob/master/components/event-publisher/org.wso2.carbon.event.publisher.core/src/main/java/org/wso2/carbon/event/publisher/core/internal/EventPublisher.java#L339 On Fri, Jul 22, 2016 at 12:28 PM, Sriskandarajah Suhothayan <s...@wso2.com> wrote: > > > On Fri, Jul 22, 2016 at 12:00 PM, Indunil Upeksha Rathnayake < > indu...@wso2.com> wrote: > >> Hi, >> >> Please find the meeting notes in [1]. I have following considerations >> regarding the improvements we have discussed. >> >> (1) Even though we have configured to load the email template from >> EventPublisher(analytics side), the placeholder values has to be sent as >> meta data/correlation data/payload data/arbitrary data, since in analytics >> side, the user claim values are not getting from the user store. >> In order to send the placeholder values from IS side, anyway we have to >> load the email template and retrieve the placeholders. So as I have >> understood, for email notifications, it's not needed to use the email >> template loading part in analytics, since it'll be a redundant task. (Refer >> [2]) >> > > Here we can set the claim values as arbitrary data, and the notification > specific details as the meta, correlation & payload data. > Then we can use the template loading only at the analytics side. > > >> (2) The email templates has to be changed as follows. >> i) if the value will be provided in an arbitrary data map, the >> placeholder should be with a prefix "arbitrary_" >> (ex:{{arbitrary_givenname}}) >> > ii) if the value will be provided in an meta data map, the placeholder >> should be changed as {{...}} (ex:{{givenname}}) >> >> No we should not use "arbitrary_" for any cases, its internal information > and the names should not have "arbitrary_" even if its in arbitrary data > map or otherwise. > > (3) Only Text OutputMapping Content can be filled from a value in an >> arbitrary data map using prefix "arbitrary_" . It's not possible to use a >> value of an arbitrary data map, in a Dynamic adapter properties, only a >> value from a meta data/correlation data/payload data map can be used. I >> think that need to be extended to use even an arbitrary value as a dynamic >> adapter property.(Refer [3]) >> > > @Gobi can you please fix this if that's the case. > > >> >> (4) The default stream definitions and publisher definitions has to be >> deployed on super tenant as well as other tenants as well. And when a new >> tenant is added, those streams and publishers has to be deployed for that >> particular tenant as well. >> >> We can have a tenant creation handler to do this copying during that > tenant creation time. WDYT? > > Really appreciate your ideas/suggestions regarding the above mentioned >> concerns. >> >> [1] Invitation: [Architecture] [Discussion] Improvement to use Siddhi >> str... @ Wed Jul 20, 2016 4:30pm - 5:30pm (IST) (indu...@wso2.com) >> >> [2] >> https://github.com/wso2/carbon-analytics-common/blob/master/components/event-publisher/org.wso2.carbon.event.publisher.core/src/main/java/org/wso2/carbon/event/publisher/core/internal/type/text/TextOutputMapper.java#L108 >> >> [3] >> https://github.com/wso2/carbon-analytics-common/blob/master/components/event-publisher/org.wso2.carbon.event.publisher.core/src/main/java/org/wso2/carbon/event/publisher/core/internal/EventPublisher.java#L311 >> >> Thanks and Regards >> -- >> Indunil Upeksha Rathnayake >> Software Engineer | WSO2 Inc >> Email indu...@wso2.com >> Mobile 0772182255 >> >> >> > > > -- > > *S. Suhothayan* > Associate Director / Architect & Team Lead of WSO2 Complex Event Processor > *WSO2 Inc. *http://wso2.com > * <http://wso2.com/>* > lean . enterprise . middleware > > > *cell: (+94) 779 756 757 <%28%2B94%29%20779%20756%20757> | blog: > http://suhothayan.blogspot.com/ <http://suhothayan.blogspot.com/>twitter: > http://twitter.com/suhothayan <http://twitter.com/suhothayan> | linked-in: > http://lk.linkedin.com/in/suhothayan <http://lk.linkedin.com/in/suhothayan>* > -- *Gobinath **Loganathan* Software Engineer, WSO2 Inc. http://wso2.com Email : gobin...@wso2.com Mobile : (+94) 770 780 210 Blog : javahelps.com <http://www.javahelps.com/>
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
