Github user echarles commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-200906016
@Leemoonsoo I have a list of comments and actions (mainly coming from
@jeffsteinmetz) I had planned to work out this weekend. You PR comes to the
point. I scrolled through.
- Good idea to reuse the rscala from the spark dist.
- I would prefer keeping the SparkRInterpreterTest with it PowerMock (to
mock static) which does not need any R on the host and add indeed as you did an
integration test which needs R on the host.
- I see you changed something for the SPARK_HOME which didn't work as
@jeffsteinmetz pointer - will look this we.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
