----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/#review1120 -----------------------------------------------------------
1) src/recipes/election has been added recently to trunk, are changes needed there as well? (see my comments below - seems like if we separated out pkg building from regular build it would make this more explicit/obvious) 2) i've been wondering for a while, perhaps we should have different scripts for zkServer.sh depending upon whether running in "development mode" and running in "package mode". There's alot of cruft in there having to do with determining which mode we are in and then setting up appropriately (zkCli, zkServer, zkCleanup, etc...). ./bin/zkEnv.sh <https://reviews.apache.org/r/1143/#comment2312> this was recently changed by ZOOKEEPER-1084 to either use the variable if passed, or use ../conf (but not ../etc) ./build.xml <https://reviews.apache.org/r/1143/#comment2310> in my case aclocal does not reside in /usr/local... (ubuntu natty) but rather /usr/share can we determine this in some other way? ./build.xml <https://reviews.apache.org/r/1143/#comment2311> I think this is going to cause problems for our normal release - we don't compile the c bindings as part of this process. This should be separated out. I think what we'd really need is to have separate targets for building the source artifact, and any additional "binary convenience" artifacts. Avro does this very successfully. How about separating out the building of packages entirely from building/testing the java code? Say by having a separate build-packages.xml (ant build file) instead? ./ivy.xml <https://reviews.apache.org/r/1143/#comment2296> jdeb is listed as a default dependency, shouldn't this only be used for building, not default? (similar to say rat) ./src/contrib/zkpython/ivy.xml <https://reviews.apache.org/r/1143/#comment2314> sorry, why do we need this in zkpython? ./src/contrib/zkpython/ivy.xml <https://reviews.apache.org/r/1143/#comment2298> replace Hadoop with ZooKeeper ./src/contrib/zkpython/src/packages/deb/zkpython.control/control <https://reviews.apache.org/r/1143/#comment2299> maintainer should be dev@zookeeper ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec <https://reviews.apache.org/r/1143/#comment2300> Hadoop? ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec <https://reviews.apache.org/r/1143/#comment2301> zookeeper rather than hadoop? ./src/packages/deb/init.d/zookeeper <https://reviews.apache.org/r/1143/#comment2304> hadoop->zookeeper ./src/packages/deb/zookeeper.control/control <https://reviews.apache.org/r/1143/#comment2306> dev@zookeeper ? ./src/packages/rpm/spec/zookeeper.spec <https://reviews.apache.org/r/1143/#comment2307> zookeeper ./src/packages/rpm/spec/zookeeper.spec <https://reviews.apache.org/r/1143/#comment2308> zookeeper? ./src/packages/templates/conf/zoo.cfg <https://reviews.apache.org/r/1143/#comment2309> is there a way to not duplicate this? (a sample is also in conf) ./src/packages/update-zookeeper-env.sh <https://reviews.apache.org/r/1143/#comment2303> the group used is hadoop? (seems fine, just wondering...) - Patrick On 2011-07-19 22:15:38, Patrick Hunt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1143/ > ----------------------------------------------------------- > > (Updated 2011-07-19 22:15:38) > > > Review request for zookeeper and Mahadev Konar. > > > Summary > ------- > > This goal of this ticket is to generate a set of RPM/debian package which > integrate well with RPM sets created by HADOOP-6255. > > > This addresses bug ZOOKEEPER-999. > https://issues.apache.org/jira/browse/ZOOKEEPER-999 > > > Diffs > ----- > > ./bin/zkCleanup.sh 1141173 > ./bin/zkCli.sh 1141173 > ./bin/zkEnv.sh 1141173 > ./bin/zkServer.sh 1141173 > ./build.xml 1141176 > ./ivy.xml 1141173 > ./src/contrib/build-contrib.xml 1141173 > ./src/contrib/build.xml 1141173 > ./src/contrib/zkpython/build.xml 1141173 > ./src/contrib/zkpython/ivy.xml PRE-CREATION > ./src/contrib/zkpython/src/packages/deb/zkpython.control/control > PRE-CREATION > ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION > ./src/contrib/zkpython/src/python/setup.py 1141173 > ./src/packages/deb/init.d/zookeeper PRE-CREATION > ./src/packages/deb/zookeeper.control/conffile PRE-CREATION > ./src/packages/deb/zookeeper.control/control PRE-CREATION > ./src/packages/deb/zookeeper.control/postinst PRE-CREATION > ./src/packages/deb/zookeeper.control/postrm PRE-CREATION > ./src/packages/deb/zookeeper.control/preinst PRE-CREATION > ./src/packages/deb/zookeeper.control/prerm PRE-CREATION > ./src/packages/rpm/init.d/zookeeper PRE-CREATION > ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION > ./src/packages/templates/conf/zoo.cfg PRE-CREATION > ./src/packages/update-zookeeper-env.sh PRE-CREATION > ./src/recipes/build-recipes.xml 1141173 > ./src/recipes/build.xml 1141173 > ./src/recipes/lock/build.xml 1141173 > ./src/recipes/queue/build.xml 1141173 > > Diff: https://reviews.apache.org/r/1143/diff > > > Testing > ------- > > > Thanks, > > Patrick > >
