> On 2011-07-19 22:46:10, Patrick Hunt wrote: > > 1) src/recipes/election has been added recently to trunk, are changes > > needed there as well? (see my comments below - seems like if we separated > > out pkg building from regular build it would make this more > > explicit/obvious) > > > > 2) i've been wondering for a while, perhaps we should have different > > scripts for zkServer.sh depending upon whether running in "development > > mode" and running in "package mode". There's alot of cruft in there having > > to do with determining which mode we are in and then setting up > > appropriately (zkCli, zkServer, zkCleanup, etc...). > > Patrick Hunt wrote: > What do you think of this idea (2 in particular?) I guess hadoop is fine > with this mixed use? Perhaps we can take some ideas from there an apply?
1) Is there a plan to grow more recipes? If yes, I would recommend to use maven for build script because it allows submodule to call parent build profiles. We can have a centralized template for creating recipes rpm/deb packages. Ant recursive structure is difficult to maintain because the subdirectory build.xml file needs to refer to parent build.xml to include packaging templates, which generates too much repetitive tasks. Let's put recipes packaging as a separate task for future enhancement. 2) Code reuse would be ideal. I am not sure if we want to have different scripts, perhaps consolidated functions would be sufficient to make organization cleaner. - Eric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/#review1120 ----------------------------------------------------------- On 2011-07-19 22:15:38, Patrick Hunt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1143/ > ----------------------------------------------------------- > > (Updated 2011-07-19 22:15:38) > > > Review request for zookeeper and Mahadev Konar. > > > Summary > ------- > > This goal of this ticket is to generate a set of RPM/debian package which > integrate well with RPM sets created by HADOOP-6255. > > > This addresses bug ZOOKEEPER-999. > https://issues.apache.org/jira/browse/ZOOKEEPER-999 > > > Diffs > ----- > > ./bin/zkCleanup.sh 1141173 > ./bin/zkCli.sh 1141173 > ./bin/zkEnv.sh 1141173 > ./bin/zkServer.sh 1141173 > ./build.xml 1141176 > ./ivy.xml 1141173 > ./src/contrib/build-contrib.xml 1141173 > ./src/contrib/build.xml 1141173 > ./src/contrib/zkpython/build.xml 1141173 > ./src/contrib/zkpython/ivy.xml PRE-CREATION > ./src/contrib/zkpython/src/packages/deb/zkpython.control/control > PRE-CREATION > ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION > ./src/contrib/zkpython/src/python/setup.py 1141173 > ./src/packages/deb/init.d/zookeeper PRE-CREATION > ./src/packages/deb/zookeeper.control/conffile PRE-CREATION > ./src/packages/deb/zookeeper.control/control PRE-CREATION > ./src/packages/deb/zookeeper.control/postinst PRE-CREATION > ./src/packages/deb/zookeeper.control/postrm PRE-CREATION > ./src/packages/deb/zookeeper.control/preinst PRE-CREATION > ./src/packages/deb/zookeeper.control/prerm PRE-CREATION > ./src/packages/rpm/init.d/zookeeper PRE-CREATION > ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION > ./src/packages/templates/conf/zoo.cfg PRE-CREATION > ./src/packages/update-zookeeper-env.sh PRE-CREATION > ./src/recipes/build-recipes.xml 1141173 > ./src/recipes/build.xml 1141173 > ./src/recipes/lock/build.xml 1141173 > ./src/recipes/queue/build.xml 1141173 > > Diff: https://reviews.apache.org/r/1143/diff > > > Testing > ------- > > > Thanks, > > Patrick > >
