> On 2011-07-19 22:46:10, Patrick Hunt wrote: > > ./bin/zkEnv.sh, lines 31-35 > > <https://reviews.apache.org/r/1143/diff/1/?file=26344#file26344line31> > > > > this was recently changed by ZOOKEEPER-1084 to either use the variable > > if passed, or use ../conf (but not ../etc)
Hadoop stack software used the same pattern *_HOME/conf for configuration directory. This naming convention doesn't work when *_HOME/conf is collapsed into a single directory, (i.e. /usr) A proposal maded in HADOOP-6255 to address this issue. For packaged software, $PREFIX/etc/$project will be the naming convention for configuration directory. For developer, it will use $PREFIX/conf for source code build. This patch already merged change for ZOOKEEPER-1084, it will honor $ZOOCFGDIR if it is defined. > On 2011-07-19 22:46:10, Patrick Hunt wrote: > > ./build.xml, line 155 > > <https://reviews.apache.org/r/1143/diff/1/?file=26346#file26346line155> > > > > in my case aclocal does not reside in /usr/local... (ubuntu natty) but > > rather /usr/share > > > > can we determine this in some other way? I am fine to use /usr/share as default. It is also possible to overwrite this in build.properties. Conditional checking to set property is not pretty in ant, it may be better to leave this as a property for now. > On 2011-07-19 22:46:10, Patrick Hunt wrote: > > ./build.xml, line 627 > > <https://reviews.apache.org/r/1143/diff/1/?file=26346#file26346line627> > > > > I think this is going to cause problems for our normal release - we > > don't compile the c bindings as part of this process. This should be > > separated out. > > > > I think what we'd really need is to have separate targets for building > > the source artifact, and any additional "binary convenience" artifacts. > > Avro does this very successfully. > > > > How about separating out the building of packages entirely from > > building/testing the java code? Say by having a separate build-packages.xml > > (ant build file) instead? We can skip compile-native. There is a package-native target for rpm. I will make the change. > On 2011-07-19 22:46:10, Patrick Hunt wrote: > > ./ivy.xml, line 52 > > <https://reviews.apache.org/r/1143/diff/1/?file=26347#file26347line52> > > > > jdeb is listed as a default dependency, shouldn't this only be used for > > building, not default? (similar to say rat) I will change from "default" to "package" to be sure jdeb is not included in release tarball. > On 2011-07-19 22:46:10, Patrick Hunt wrote: > > ./src/contrib/zkpython/ivy.xml, line 1 > > <https://reviews.apache.org/r/1143/diff/1/?file=26351#file26351line1> > > > > sorry, why do we need this in zkpython? Only jdeb is required for packaging. I will trim down the ivy.xml. > On 2011-07-19 22:46:10, Patrick Hunt wrote: > > ./src/packages/update-zookeeper-env.sh, line 131 > > <https://reviews.apache.org/r/1143/diff/1/?file=26365#file26365line131> > > > > the group used is hadoop? (seems fine, just wondering...) I set the full stack of the software to be ownership by group hadoop for easier file ownership management. > On 2011-07-19 22:46:10, Patrick Hunt wrote: > > ./src/packages/templates/conf/zoo.cfg, lines 1-12 > > <https://reviews.apache.org/r/1143/diff/1/?file=26364#file26364line1> > > > > is there a way to not duplicate this? (a sample is also in conf) How about generate conf/zoo_sample.cfg from src/packages/templates/conf/zoo.cfg as part of the build process? - Eric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/#review1120 ----------------------------------------------------------- On 2011-07-19 22:15:38, Patrick Hunt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1143/ > ----------------------------------------------------------- > > (Updated 2011-07-19 22:15:38) > > > Review request for zookeeper and Mahadev Konar. > > > Summary > ------- > > This goal of this ticket is to generate a set of RPM/debian package which > integrate well with RPM sets created by HADOOP-6255. > > > This addresses bug ZOOKEEPER-999. > https://issues.apache.org/jira/browse/ZOOKEEPER-999 > > > Diffs > ----- > > ./bin/zkCleanup.sh 1141173 > ./bin/zkCli.sh 1141173 > ./bin/zkEnv.sh 1141173 > ./bin/zkServer.sh 1141173 > ./build.xml 1141176 > ./ivy.xml 1141173 > ./src/contrib/build-contrib.xml 1141173 > ./src/contrib/build.xml 1141173 > ./src/contrib/zkpython/build.xml 1141173 > ./src/contrib/zkpython/ivy.xml PRE-CREATION > ./src/contrib/zkpython/src/packages/deb/zkpython.control/control > PRE-CREATION > ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION > ./src/contrib/zkpython/src/python/setup.py 1141173 > ./src/packages/deb/init.d/zookeeper PRE-CREATION > ./src/packages/deb/zookeeper.control/conffile PRE-CREATION > ./src/packages/deb/zookeeper.control/control PRE-CREATION > ./src/packages/deb/zookeeper.control/postinst PRE-CREATION > ./src/packages/deb/zookeeper.control/postrm PRE-CREATION > ./src/packages/deb/zookeeper.control/preinst PRE-CREATION > ./src/packages/deb/zookeeper.control/prerm PRE-CREATION > ./src/packages/rpm/init.d/zookeeper PRE-CREATION > ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION > ./src/packages/templates/conf/zoo.cfg PRE-CREATION > ./src/packages/update-zookeeper-env.sh PRE-CREATION > ./src/recipes/build-recipes.xml 1141173 > ./src/recipes/build.xml 1141173 > ./src/recipes/lock/build.xml 1141173 > ./src/recipes/queue/build.xml 1141173 > > Diff: https://reviews.apache.org/r/1143/diff > > > Testing > ------- > > > Thanks, > > Patrick > >
