----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/#review1140 -----------------------------------------------------------
a few small issues ./build.xml <https://reviews.apache.org/r/1143/#comment2369> yes, much nicer. we should add building pkgs as a job on jenkins - to verify we don't break this/other things. (would you mind filing a jira?) ./src/contrib/zkpython/ivy.xml <https://reviews.apache.org/r/1143/#comment2370> zookeeper? ./src/packages/templates/conf/zoo.cfg <https://reviews.apache.org/r/1143/#comment2371> no longer needed? ./build.xml <https://reviews.apache.org/r/1143/#comment2372> don't you mean to have a dependency on package-native here rather than compile-native? - Patrick On 2011-07-20 17:45:08, Patrick Hunt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1143/ > ----------------------------------------------------------- > > (Updated 2011-07-20 17:45:08) > > > Review request for zookeeper and Mahadev Konar. > > > Summary > ------- > > This goal of this ticket is to generate a set of RPM/debian package which > integrate well with RPM sets created by HADOOP-6255. > > > This addresses bug ZOOKEEPER-999. > https://issues.apache.org/jira/browse/ZOOKEEPER-999 > > > Diffs > ----- > > ./bin/zkCleanup.sh 1148587 > ./bin/zkCli.sh 1148587 > ./bin/zkEnv.sh 1148587 > ./bin/zkServer.sh 1148587 > ./build.xml 1148587 > ./ivy.xml 1148587 > ./src/contrib/build-contrib.xml 1148587 > ./src/contrib/build.xml 1148587 > ./src/contrib/zkpython/build.xml 1148587 > ./src/contrib/zkpython/ivy.xml PRE-CREATION > ./src/contrib/zkpython/src/packages/deb/zkpython.control/control > PRE-CREATION > ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION > ./src/contrib/zkpython/src/python/setup.py 1148587 > ./src/packages/deb/init.d/zookeeper PRE-CREATION > ./src/packages/deb/zookeeper.control/conffile PRE-CREATION > ./src/packages/deb/zookeeper.control/control PRE-CREATION > ./src/packages/deb/zookeeper.control/postinst PRE-CREATION > ./src/packages/deb/zookeeper.control/postrm PRE-CREATION > ./src/packages/deb/zookeeper.control/preinst PRE-CREATION > ./src/packages/deb/zookeeper.control/prerm PRE-CREATION > ./src/packages/rpm/init.d/zookeeper PRE-CREATION > ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION > ./src/packages/templates/conf/zookeeper-env.sh PRE-CREATION > ./src/packages/update-zookeeper-env.sh PRE-CREATION > ./src/recipes/build-recipes.xml 1148587 > ./src/recipes/build.xml 1148587 > ./src/recipes/lock/build.xml 1148587 > ./src/recipes/queue/build.xml 1148587 > > Diff: https://reviews.apache.org/r/1143/diff > > > Testing > ------- > > > Thanks, > > Patrick > >
