> On 2011-07-22 18:50:04, Patrick Hunt wrote:
> > The packaging code itself looks pretty good now. I've moved on to verifying 
> > the installation, however I see issues installing the deb on a clean ubuntu 
> > 10.10. Can you try generating the packages, install them and work through 
> > these? (ie test on ubuntu and rhel/centos).
> > 
> > 1) the following during install:
> > 
> > Setting up zookeeper (3.4.0) ...
> > ln: creating symbolic link `/usr/etc/zookeeper': No such file or directory
> > 
> > 2) I'm unable to start the server, seems like number of issues: a) why 
> > /usr/sbin/../etc/zookeeper for config, should just be /etc/zookeeper no? b) 
> > permission issues, notice I am running this as sudo.
> > 
> > sudo /etc/init.d/zookeeper start
> >  * Starting Apache ZooKeeper server zookeeper                               
> >                       JMX enabled by default
> > Using config: /usr/sbin/../etc/zookeeper/zoo.cfg
> > grep: /usr/sbin/../etc/zookeeper/zoo.cfg: No such file or directory
> > mkdir: cannot create directory `': No such file or directory
> > Starting zookeeper ... /usr/bin/../sbin/zkServer.sh: line 109: 
> > /zookeeper_server.pid: Permission denied
> > FAILED TO WRITE PID
> > /usr/bin/../sbin/zkServer.sh: line 105: ./zookeeper.out: Permission denied
> >                                                                             
> >                [fail]
> >
> 
> Eric Yang wrote:
>     1,2) My mistake, it should make /usr/etc and symlink /usr/etc/zookeeper 
> to /etc/zookeeper.  On my test machines (RHEL, Ubuntu), I have Hadoop 
> installed, which was making /usr/etc.  That was why it worked only on my 
> machine.  I will correct this mistake.

you might also want to specify the zk conf directory so that it shows up as 
/etc/zookeeper/zoo.cfg on the cmdline. (no worries)


> On 2011-07-22 18:50:04, Patrick Hunt wrote:
> > ./src/packages/deb/zookeeper.control/control, line 6
> > <https://reviews.apache.org/r/1143/diff/3-4/?file=26615#file26615line6>
> >
> >     should we depend on either the jre or the jdk?
> 
> Eric Yang wrote:
>     I have no problem using ZooKeeper with only JRE installed.

yes, that's fine, my point is that someone else may only have the jdk 
installed, shouldn't they be able to run w/o installing jre (on ubuntu at least 
there is no dependency btw jre/jdk afaict).


> On 2011-07-22 18:50:04, Patrick Hunt wrote:
> > ./README_packaging.txt, line 1
> > <https://reviews.apache.org/r/1143/diff/4/?file=26874#file26874line1>
> >
> >     Nice!
> >     
> >     Would be nice to add - when I build where are the generated deb/rpm 
> > files placed?
> >     
> >     Are there any requirements for building? (I don't think so, but I'm not 
> > sure)
> 
> Eric Yang wrote:
>     cppunit, and python-setuptools are required.  Will include those in 
> README_packaging.txt.

well those are required to build zk itself. you probably shouldn't add that, I 
was just thinking if anything pkging related was required.


- Patrick


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1143/#review1169
-----------------------------------------------------------


On 2011-07-22 18:24:20, Patrick Hunt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1143/
> -----------------------------------------------------------
> 
> (Updated 2011-07-22 18:24:20)
> 
> 
> Review request for zookeeper and Mahadev Konar.
> 
> 
> Summary
> -------
> 
> This goal of this ticket is to generate a set of RPM/debian package which 
> integrate well with RPM sets created by HADOOP-6255.
> 
> 
> This addresses bug ZOOKEEPER-999.
>     https://issues.apache.org/jira/browse/ZOOKEEPER-999
> 
> 
> Diffs
> -----
> 
>   ./README_packaging.txt PRE-CREATION 
>   ./bin/zkCleanup.sh 1148587 
>   ./bin/zkCli.sh 1148587 
>   ./bin/zkEnv.sh 1148587 
>   ./bin/zkServer.sh 1148587 
>   ./build.xml 1148587 
>   ./ivy.xml 1148587 
>   ./src/contrib/build-contrib.xml 1148587 
>   ./src/contrib/build.xml 1148587 
>   ./src/contrib/zkpython/build.xml 1148587 
>   ./src/contrib/zkpython/ivy.xml PRE-CREATION 
>   ./src/contrib/zkpython/src/packages/deb/zkpython.control/control 
> PRE-CREATION 
>   ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION 
>   ./src/contrib/zkpython/src/python/setup.py 1148587 
>   ./src/packages/deb/init.d/zookeeper PRE-CREATION 
>   ./src/packages/deb/zookeeper.control/conffile PRE-CREATION 
>   ./src/packages/deb/zookeeper.control/control PRE-CREATION 
>   ./src/packages/deb/zookeeper.control/postinst PRE-CREATION 
>   ./src/packages/deb/zookeeper.control/postrm PRE-CREATION 
>   ./src/packages/deb/zookeeper.control/preinst PRE-CREATION 
>   ./src/packages/deb/zookeeper.control/prerm PRE-CREATION 
>   ./src/packages/rpm/init.d/zookeeper PRE-CREATION 
>   ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION 
>   ./src/packages/templates/conf/zookeeper-env.sh PRE-CREATION 
>   ./src/packages/update-zookeeper-env.sh PRE-CREATION 
>   ./src/recipes/build-recipes.xml 1148587 
>   ./src/recipes/build.xml 1148587 
>   ./src/recipes/lock/build.xml 1148587 
>   ./src/recipes/queue/build.xml 1148587 
> 
> Diff: https://reviews.apache.org/r/1143/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Patrick
> 
>

Reply via email to