> On 2011-07-21 06:02:33, Patrick Hunt wrote: > > I ran "ant deb" successfully, although I have not yet tried to install it. > > I noticed a couple issues with the generated package. > > > > shouldn't /etc/zookeeper contain zoo.cfg? > > > > drwxr-xr-x 0/0 0 2011-07-20 22:41 ./etc/ > > drwxr-xr-x 0/0 0 2011-07-20 22:41 ./etc/zookeeper/ > > -rw-r--r-- 0/0 535 2011-07-20 22:41 > > ./etc/zookeeper/configuration.xsl > > -rw-r--r-- 0/0 2161 2011-07-20 22:41 > > ./etc/zookeeper/log4j.properties > > -rw-r--r-- 0/0 447 2011-07-20 22:41 > > ./etc/zookeeper/zoo_sample.cfg > > > > shouldn't we be creating (if doesn't exist) the /var/lib/zookeeper > > directory? ZK does this currently, however I'm planning to file a bug for > > this - really we shouldn't come up if we can't find this directory (handles > > case of misconfiguration - we stop rather than start with an empty data > > hierarchy) > > > > Can you add some documentation? Nothing fancy, perhaps a > > README_packaging.txt at the toplevel that describes the currently supported > > packages, some basic information about them, how to build "ant deb" etc..., > > additional requirements to build, etc... something basic to help out > > someone trying to build the packages.
The system should generate zoo.cfg, if it doesn't exist. It looks like a bug. I will look into it. I will add README_packaging.txt in the next patch. Same for sun jdk. - Eric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/#review1149 ----------------------------------------------------------- On 2011-07-22 18:24:20, Patrick Hunt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1143/ > ----------------------------------------------------------- > > (Updated 2011-07-22 18:24:20) > > > Review request for zookeeper and Mahadev Konar. > > > Summary > ------- > > This goal of this ticket is to generate a set of RPM/debian package which > integrate well with RPM sets created by HADOOP-6255. > > > This addresses bug ZOOKEEPER-999. > https://issues.apache.org/jira/browse/ZOOKEEPER-999 > > > Diffs > ----- > > ./README_packaging.txt PRE-CREATION > ./bin/zkCleanup.sh 1148587 > ./bin/zkCli.sh 1148587 > ./bin/zkEnv.sh 1148587 > ./bin/zkServer.sh 1148587 > ./build.xml 1148587 > ./ivy.xml 1148587 > ./src/contrib/build-contrib.xml 1148587 > ./src/contrib/build.xml 1148587 > ./src/contrib/zkpython/build.xml 1148587 > ./src/contrib/zkpython/ivy.xml PRE-CREATION > ./src/contrib/zkpython/src/packages/deb/zkpython.control/control > PRE-CREATION > ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION > ./src/contrib/zkpython/src/python/setup.py 1148587 > ./src/packages/deb/init.d/zookeeper PRE-CREATION > ./src/packages/deb/zookeeper.control/conffile PRE-CREATION > ./src/packages/deb/zookeeper.control/control PRE-CREATION > ./src/packages/deb/zookeeper.control/postinst PRE-CREATION > ./src/packages/deb/zookeeper.control/postrm PRE-CREATION > ./src/packages/deb/zookeeper.control/preinst PRE-CREATION > ./src/packages/deb/zookeeper.control/prerm PRE-CREATION > ./src/packages/rpm/init.d/zookeeper PRE-CREATION > ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION > ./src/packages/templates/conf/zookeeper-env.sh PRE-CREATION > ./src/packages/update-zookeeper-env.sh PRE-CREATION > ./src/recipes/build-recipes.xml 1148587 > ./src/recipes/build.xml 1148587 > ./src/recipes/lock/build.xml 1148587 > ./src/recipes/queue/build.xml 1148587 > > Diff: https://reviews.apache.org/r/1143/diff > > > Testing > ------- > > > Thanks, > > Patrick > >
