> On 2011-07-22 18:50:04, Patrick Hunt wrote: > > ./src/contrib/zkpython/src/packages/deb/zkpython.control/control, line 1 > > <https://reviews.apache.org/r/1143/diff/4/?file=26885#file26885line1> > > > > missing license - is there a way to add comments here or no? > > Eric Yang wrote: > Will do.
I did, ZOOKEEPER-999-9.patch shows the license, but for some reason review board isn't picking up the additions. > On 2011-07-22 18:50:04, Patrick Hunt wrote: > > ./README_packaging.txt, line 1 > > <https://reviews.apache.org/r/1143/diff/4/?file=26874#file26874line1> > > > > Nice! > > > > Would be nice to add - when I build where are the generated deb/rpm > > files placed? > > > > Are there any requirements for building? (I don't think so, but I'm not > > sure) > > Eric Yang wrote: > cppunit, and python-setuptools are required. Will include those in > README_packaging.txt. > > Patrick Hunt wrote: > well those are required to build zk itself. you probably shouldn't add > that, I was just thinking if anything pkging related was required. For rpm, it will require RHEL or CentOS because it depends on rpmbuild. Debian build is base on java plugin, hence it can build on both RHEL or Ubuntu. > On 2011-07-22 18:50:04, Patrick Hunt wrote: > > ./src/packages/deb/zookeeper.control/control, line 6 > > <https://reviews.apache.org/r/1143/diff/3-4/?file=26615#file26615line6> > > > > should we depend on either the jre or the jdk? > > Eric Yang wrote: > I have no problem using ZooKeeper with only JRE installed. > > Patrick Hunt wrote: > yes, that's fine, my point is that someone else may only have the jdk > installed, shouldn't they be able to run w/o installing jre (on ubuntu at > least there is no dependency btw jre/jdk afaict). I just tested installing sun-java6-jdk without jre on Ubuntu 11.04. It doesn't let me install. I think the dependency is right. - Eric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/#review1169 ----------------------------------------------------------- On 2011-07-22 18:24:20, Patrick Hunt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1143/ > ----------------------------------------------------------- > > (Updated 2011-07-22 18:24:20) > > > Review request for zookeeper and Mahadev Konar. > > > Summary > ------- > > This goal of this ticket is to generate a set of RPM/debian package which > integrate well with RPM sets created by HADOOP-6255. > > > This addresses bug ZOOKEEPER-999. > https://issues.apache.org/jira/browse/ZOOKEEPER-999 > > > Diffs > ----- > > ./README_packaging.txt PRE-CREATION > ./bin/zkCleanup.sh 1148587 > ./bin/zkCli.sh 1148587 > ./bin/zkEnv.sh 1148587 > ./bin/zkServer.sh 1148587 > ./build.xml 1148587 > ./ivy.xml 1148587 > ./src/contrib/build-contrib.xml 1148587 > ./src/contrib/build.xml 1148587 > ./src/contrib/zkpython/build.xml 1148587 > ./src/contrib/zkpython/ivy.xml PRE-CREATION > ./src/contrib/zkpython/src/packages/deb/zkpython.control/control > PRE-CREATION > ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION > ./src/contrib/zkpython/src/python/setup.py 1148587 > ./src/packages/deb/init.d/zookeeper PRE-CREATION > ./src/packages/deb/zookeeper.control/conffile PRE-CREATION > ./src/packages/deb/zookeeper.control/control PRE-CREATION > ./src/packages/deb/zookeeper.control/postinst PRE-CREATION > ./src/packages/deb/zookeeper.control/postrm PRE-CREATION > ./src/packages/deb/zookeeper.control/preinst PRE-CREATION > ./src/packages/deb/zookeeper.control/prerm PRE-CREATION > ./src/packages/rpm/init.d/zookeeper PRE-CREATION > ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION > ./src/packages/templates/conf/zookeeper-env.sh PRE-CREATION > ./src/packages/update-zookeeper-env.sh PRE-CREATION > ./src/recipes/build-recipes.xml 1148587 > ./src/recipes/build.xml 1148587 > ./src/recipes/lock/build.xml 1148587 > ./src/recipes/queue/build.xml 1148587 > > Diff: https://reviews.apache.org/r/1143/diff > > > Testing > ------- > > > Thanks, > > Patrick > >
