I'm running the build on my local windows box right now. I am seeing some test failures, although the number of failures is much less. I'll update the jira when I finish running the test.
Also, I just noticed that ZooKeeper-trunk-WinVS2008_java has been timing out. I didn't know ZooKeeper-trunk-WinVS2008 doesn't run ant test, and I somehow assumed the gray status means the build is disabled. I increased the timeout from 2 hours to 4 hours and restart the test. I'm pretty sure it'll fail, but at least we'll know that it's not just 3.4 branch that's broken. On Thu, Dec 12, 2013 at 1:27 PM, Flavio Junqueira <[email protected]> wrote: > Good points. I'm not sure if the client being being closed is what is causing > the test failure, but it is not a bad guess. I think we need to execute > ensureAll only in the case we add the client. The observation about > ensureOnly seems right to me. > > We will need to get those in to get Jenkins to run. Do you want to create a > subtask of ZK-1833 and propose these changes in a patch? If you propose a > patch, we can give it a try and see. > > There are other failures unrelated to this, though. Example: > > [junit] 2013-12-12 08:55:48,245 [myid:] - INFO [main:ZKTestCase$1@65] - > FAILED testStartupFailureCreate > [junit] org.junit.internal.runners.model.MultipleFailureException > [junit] at > org.junit.internal.runners.model.MultipleFailureException.assertEmpty(MultipleFailureException.java:23) > [junit] at > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:42) > [junit] at > org.junit.rules.TestWatchman$1.evaluate(TestWatchman.java:48) > [junit] at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:76) > [junit] at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50) > [junit] at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193) > [junit] at > org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52) > [junit] at > org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191) > [junit] at > org.junit.runners.ParentRunner.access$000(ParentRunner.java:42) > [junit] at > org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184) > [junit] at org.junit.runners.ParentRunner.run(ParentRunner.java:236) > [junit] at > junit.framework.JUnit4TestAdapter.run(JUnit4TestAdapter.java:39) > [junit] at > org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:518) > [junit] at > org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:1052) > [junit] at > org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:906) > > On Dec 12, 2013, at 7:07 PM, German Blanco <[email protected]> > wrote: > >> ... there is a similar situation in JMXEnv.java:138. It seems that >> "ensureOnly" gets call before the previously invoked shutdown has completed. >> The problem here is that one needs the Jenkins build in order to test what >> is really happening :-( >> >> >> On Thu, Dec 12, 2013 at 7:57 PM, German Blanco < >> [email protected]> wrote: >> >>> Hello Flavio, >>> >>> this looks great now, only one small problem and the deployment to go! >>> Congratulations! >>> >>> I have taken a look at the windows build in Jenkins, and I am going to >>> make a wild guess at what it might be happening, I hope it is worth >>> anything. >>> In many of the errors, the assertion in JMXEnv.java:115 is failing. >>> The call is from ClientBase.java:197. I see something strange there, it >>> seems that the procedure might close the client in one of the conditions >>> (line 193) and still then check that it is there in line 197. So if closing >>> is fast enough, the checking fails. Could that be it? >>> >>> Regards, >>> >>> German. >>> >>> >>> On Thu, Dec 12, 2013 at 5:24 PM, FPJ <[email protected]> wrote: >>> >>>> There are two issues blocking 3.4.6 now: >>>> >>>> >>>> >>>> - I don't understand why the 3.4 windows build in failing on >>>> Jenkins. Tests seem to pass fine on Windows for me. If anyone is willing >>>> to >>>> have a look, I would appreciate some help. >>>> >>>> - ZK-1430 needs to get in and I'd like to understand what needs >>>> to >>>> be done for ZK-1402. >>>> >>>> >>>> >>>> Thanks, >>>> >>>> -Flavio >>>> >>>> >>> >
