----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19089/#review36935 -----------------------------------------------------------
./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java <https://reviews.apache.org/r/19089/#comment68122> hmm, so at what point do we check if this dir exists then? ./src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java <https://reviews.apache.org/r/19089/#comment68120> nit: coding style (if (autocreate) {) ./src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java <https://reviews.apache.org/r/19089/#comment68121> nit: coding style (spaces around else) ./src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java <https://reviews.apache.org/r/19089/#comment68123> no need to create this dir? ./src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java <https://reviews.apache.org/r/19089/#comment68124> we already depend on Apache Commons, so you could use separatorsToSystem(): http://people.apache.org/~jochen/commons-io/site/apidocs/org/apache/commons/io/FilenameUtils.html#separatorsToSystem%28java.lang.String%29 - Raul Gutierrez Segales On March 12, 2014, 4:17 a.m., Rakesh R wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19089/ > ----------------------------------------------------------- > > (Updated March 12, 2014, 4:17 a.m.) > > > Review request for zookeeper, fpj, michim, and Raul Gutierrez Segales. > > > Bugs: ZOOKEEPER-1878 > https://issues.apache.org/jira/browse/ZOOKEEPER-1878 > > > Repository: zookeeper > > > Description > ------- > > See ZOOKEEPER-1878 > > > Diffs > ----- > > ./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java > 1566210 > ./src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java > 1566210 > > Diff: https://reviews.apache.org/r/19089/diff/ > > > Testing > ------- > > Test included > > > Thanks, > > Rakesh R > >
