> On March 12, 2014, 5:43 p.m., Raul Gutierrez Segales wrote: > > ./src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java, > > line 67 > > <https://reviews.apache.org/r/19089/diff/1/?file=517046#file517046line67> > > > > nit: coding style (if (autocreate) {)
ok, I'll modify this. > On March 12, 2014, 5:43 p.m., Raul Gutierrez Segales wrote: > > ./src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java, > > line 72 > > <https://reviews.apache.org/r/19089/diff/1/?file=517046#file517046line72> > > > > nit: coding style (spaces around else) ok, I'll modify this. > On March 12, 2014, 5:43 p.m., Raul Gutierrez Segales wrote: > > ./src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java, > > line 82 > > <https://reviews.apache.org/r/19089/diff/1/?file=517046#file517046line82> > > > > we already depend on Apache Commons, so you could use > > separatorsToSystem(): > > > > > > http://people.apache.org/~jochen/commons-io/site/apidocs/org/apache/commons/io/FilenameUtils.html#separatorsToSystem%28java.lang.String%29 Hi Raul, Please see Camille's comment. - Rakesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19089/#review36935 ----------------------------------------------------------- On March 12, 2014, 4:17 a.m., Rakesh R wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19089/ > ----------------------------------------------------------- > > (Updated March 12, 2014, 4:17 a.m.) > > > Review request for zookeeper, fpj, michim, and Raul Gutierrez Segales. > > > Bugs: ZOOKEEPER-1878 > https://issues.apache.org/jira/browse/ZOOKEEPER-1878 > > > Repository: zookeeper > > > Description > ------- > > See ZOOKEEPER-1878 > > > Diffs > ----- > > ./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java > 1566210 > ./src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java > 1566210 > > Diff: https://reviews.apache.org/r/19089/diff/ > > > Testing > ------- > > Test included > > > Thanks, > > Rakesh R > >
