> On March 12, 2014, 5:43 p.m., Raul Gutierrez Segales wrote:
> > ./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java,
> > line 274
> > <https://reviews.apache.org/r/19089/diff/1/?file=517045#file517045line274>
> >
> > hmm, so at what point do we check if this dir exists then?
There is a check already present inside the constructor of FileTxnSnapLog.
FileTxnSnapLog(File dataDir, File snapDir){
//....
if (!this.snapDir.exists()) {
}
Will this be OK?
> On March 12, 2014, 5:43 p.m., Raul Gutierrez Segales wrote:
> > ./src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java,
> > line 73
> > <https://reviews.apache.org/r/19089/diff/1/?file=517046#file517046line73>
> >
> > no need to create this dir?
I'll rename the 'autocreate' flag to 'preCreateDirs', so I hope it will avoid
confusions. Here the test expectation is, it sets
"zookeeper.datadir.autocreate" to true and won't precreate the dataDir &
dataLogDir, then zk server should create it and shouldn't throw exception.
- Rakesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19089/#review36935
-----------------------------------------------------------
On March 12, 2014, 4:17 a.m., Rakesh R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19089/
> -----------------------------------------------------------
>
> (Updated March 12, 2014, 4:17 a.m.)
>
>
> Review request for zookeeper, fpj, michim, and Raul Gutierrez Segales.
>
>
> Bugs: ZOOKEEPER-1878
> https://issues.apache.org/jira/browse/ZOOKEEPER-1878
>
>
> Repository: zookeeper
>
>
> Description
> -------
>
> See ZOOKEEPER-1878
>
>
> Diffs
> -----
>
> ./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java
> 1566210
> ./src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java
> 1566210
>
> Diff: https://reviews.apache.org/r/19089/diff/
>
>
> Testing
> -------
>
> Test included
>
>
> Thanks,
>
> Rakesh R
>
>
