> On March 12, 2014, 6:13 p.m., michim wrote: > > ./src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java, > > line 68 > > <https://reviews.apache.org/r/19089/diff/1/?file=517046#file517046line68> > > > > Can we remove this block? Doesn't the server create the data directory > > anyways?
I'll rename the 'autocreate' flag to 'preCreateDirs', so I hope it will avoid confusions. So we can verify tests with both the conditions with false/true. Is that meaningful? - Rakesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19089/#review36945 ----------------------------------------------------------- On March 12, 2014, 4:17 a.m., Rakesh R wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19089/ > ----------------------------------------------------------- > > (Updated March 12, 2014, 4:17 a.m.) > > > Review request for zookeeper, fpj, michim, and Raul Gutierrez Segales. > > > Bugs: ZOOKEEPER-1878 > https://issues.apache.org/jira/browse/ZOOKEEPER-1878 > > > Repository: zookeeper > > > Description > ------- > > See ZOOKEEPER-1878 > > > Diffs > ----- > > ./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java > 1566210 > ./src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java > 1566210 > > Diff: https://reviews.apache.org/r/19089/diff/ > > > Testing > ------- > > Test included > > > Thanks, > > Rakesh R > >
