Github user flier commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/180#discussion_r101880473
--- Diff:
src/java/main/org/apache/zookeeper/server/command/SnapCommand.java ---
@@ -0,0 +1,53 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zookeeper.server.command;
+
+import org.apache.zookeeper.server.ServerCnxn;
+import org.apache.zookeeper.server.ZooKeeperThread;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.io.PrintWriter;
+
+public class SnapCommand extends AbstractFourLetterCommand {
+ private static final Logger LOG =
LoggerFactory.getLogger(SnapCommand.class);
+
+ SnapCommand(PrintWriter pw, ServerCnxn serverCnxn) {
+ super(pw,serverCnxn);
+ }
+
+ @Override
+ public void commandRun() throws IOException {
+ if (!isZKServerRunning()) {
+ pw.println(ZK_NOT_SERVING);
+ } else {
+ Thread snapInProcess = new ZooKeeperThread("Snapshot Thread") {
+ public void run() {
+ try {
+ zkServer.takeSnapshot();
--- End diff --
I have wrapped the manual requests from `snap` command or JMX with a
`tryTakeSnapshot` method, which will skip action when there are busy. If you
believe it is necessary, we could merge the check into `takeSnapshot`, which
may impact all the server workflow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
