Github user flier commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/180#discussion_r102028465
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
@@ -126,6 +125,9 @@
private final ZooKeeperServerListener listener;
private ZooKeeperServerShutdownHandler zkShutdownHandler;
+ private volatile long lastSnapshotZxid;
+ private AtomicInteger isGeneratingSnapshot = new AtomicInteger(0);
--- End diff --
In fact, I'm not sure whether Zookeeper backend threads will take snapshot
in parallel. So, I choose to use a `AtomicInteger` to protect manual call
`takeSnapshot`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
