Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/119#discussion_r203940477
  
    --- Diff: src/java/main/org/apache/zookeeper/KeeperException.java ---
    @@ -387,6 +389,8 @@ public void setCode(int code) {
             EPHEMERALONLOCALSESSION (EphemeralOnLocalSession),
             /** Attempts to remove a non-existing watcher */
             NOWATCHER (-121),
    +        /** Not received packet timely */
    +        TIMEOUT (-122),
    --- End diff --
    
    I was thinking the same error code should be added to C client so the C 
client can react to the new error code properly, instead of crash (the worst 
case). Though, I suspect properly the C client is fine as this error code will 
not be fired on server side (it's a pure Java client thing), so maybe we are 
fine without touch C client.


---

Reply via email to