Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/119#discussion_r204626422
  
    --- Diff: src/java/main/org/apache/zookeeper/KeeperException.java ---
    @@ -387,6 +389,8 @@ public void setCode(int code) {
             EPHEMERALONLOCALSESSION (EphemeralOnLocalSession),
             /** Attempts to remove a non-existing watcher */
             NOWATCHER (-121),
    +        /** Not received packet timely */
    +        TIMEOUT (-122),
    --- End diff --
    
    We already have `OPERATIONTIMEOUT` error code, so `TIMEOUT` sound too 
generic. Instead of using `TIMEOUT`, would something more descriptive better? I 
am thinking `SERVERRESPONSETIMEOUT` (server response timeout). Consider this is 
user facing, have a descriptive name with clear semantic sounds better.


---

Reply via email to