[GitHub] zookeeper pull request #669: ZOOKEEPER-3152: Port ZK netty stack to netty4

[eolivelli]

Github user eolivelli commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/669#discussion_r226684209
  
    --- Diff: 
zookeeper-common/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java 
---
    @@ -267,7 +298,7 @@ private void sendPkt(Packet p) {
             p.createBB();
             updateLastSend();
             sentCount++;
    -        channel.write(ChannelBuffers.wrappedBuffer(p.bb));
    +        channel.writeAndFlush(Unpooled.wrappedBuffer(p.bb));
    --- End diff --
    
    What about adding ', channel.voidPromise()' ?


---