Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226756052
--- Diff:
zookeeper-common/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -267,7 +298,7 @@ private void sendPkt(Packet p) {
p.createBB();
updateLastSend();
sentCount++;
- channel.write(ChannelBuffers.wrappedBuffer(p.bb));
+ channel.writeAndFlush(Unpooled.wrappedBuffer(p.bb));
--- End diff --
Can you explain what the purpose of that would be? According to the
documentation, voidPromise() returns a promise that will never be notified of
success or failure.
---
