[GitHub] zookeeper pull request #669: ZOOKEEPER-3152: Port ZK netty stack to netty4

[ivmaykov]

Github user ivmaykov commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/669#discussion_r226756739
  
    --- Diff: 
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxn.java 
---
    @@ -200,24 +186,13 @@ public void setSessionId(long sessionId) {
             this.sessionId = sessionId;
         }
     
    -    @Override
    -    public void enableRecv() {
    -        if (throttled) {
    -            throttled = false;
    -            if (LOG.isDebugEnabled()) {
    -                LOG.debug("Sending unthrottle event " + this);
    -            }
    -            channel.getPipeline().sendUpstream(new 
ResumeMessageEvent(channel));
    -        }
    -    }
    -
         @Override
         public void sendBuffer(ByteBuffer sendBuffer) {
             if (sendBuffer == ServerCnxnFactory.closeConn) {
                 close();
                 return;
             }
    -        channel.write(wrappedBuffer(sendBuffer));
    +        channel.writeAndFlush(Unpooled.wrappedBuffer(sendBuffer));
    --- End diff --
    
    As above, I'm not sure what that provides. I am still learning about netty 
so please excuse my ignorance :)


---