Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226755668
--- Diff:
zookeeper-common/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -184,7 +213,9 @@ void cleanup() {
@Override
void close() {
- channelFactory.releaseExternalResources();
+ if (!eventLoopGroup.isShuttingDown()) {
--- End diff --
I'm not sure if calling `shutdownGracefully` more than once is allowed,
which is why I added the check. It might not be necessary.
---
