> + IA32_PAGING_ENTRY ParentPagingEntryContent; 1. how about "OriginalParentPagingEntry"?
> + IA32_PAGING_ENTRY PrevLeafPagingEntryContent; 2. how about "OriginalCurrentPagingEntry"? > > + // > + // Check if ParentPagingEntry entry is modified. > + // 3. Can you add more comments to explain why checking parent entry content is enough? > + if (ParentPagingEntryContent.Uint64 != ParentPagingEntry->Uint64) { > + if (IsModified != NULL) { 4. Can you always pass a non-NULL IsModified to MapInLevel()? 5. By the way, it's good that this patch doesn't enhance test case to test IsModified return value. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#101198): https://edk2.groups.io/g/devel/message/101198 Mute This Topic: https://groups.io/mt/97469484/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-