Can you please check that the reserved fields in 4 PDPTE entries are set to 0 in the test?
> -----Original Message----- > From: Tan, Dun <dun....@intel.com> > Sent: Wednesday, March 8, 2023 6:08 PM > To: devel@edk2.groups.io > Cc: Dong, Eric <eric.d...@intel.com>; Ni, Ray <ray...@intel.com>; Kumar, > Rahul R <rahul.r.ku...@intel.com>; Gerd Hoffmann <kra...@redhat.com> > Subject: [Patch V2 12/14] UefiCpuPkg/CpuPageTableLib: Add RandomTest > for PAE paging > > Add RandomTest for PAE paging. > > Signed-off-by: Dun Tan <dun....@intel.com> > Cc: Eric Dong <eric.d...@intel.com> > Cc: Ray Ni <ray...@intel.com> > Cc: Rahul Kumar <rahul1.ku...@intel.com> > Cc: Gerd Hoffmann <kra...@redhat.com> > --- > > UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTestHo > st.c | 2 ++ > UefiCpuPkg/Library/CpuPageTableLib/UnitTest/RandomTest.c | > 3 +- > - > UefiCpuPkg/Library/CpuPageTableLib/UnitTest/TestHelper.c | > 5 ++- > -- > 3 files changed, 5 insertions(+), 5 deletions(-) > > diff --git > a/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTest > Host.c > b/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTest > Host.c > index 3df6436af3..06a8fd3c02 100644 > --- > a/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTest > Host.c > +++ > b/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTest > Host.c > @@ -9,6 +9,7 @@ > #include "CpuPageTableLibUnitTest.h" > > // ----------------------------------------------------------------------- > PageMode-- > TestCount-TestRangeCount---RandomOptions > +static CPU_PAGE_TABLE_LIB_RANDOM_TEST_CONTEXT > mTestContextPagingPae = { PagingPae, 100, 20, USE_RANDOM_ARRAY }; > static CPU_PAGE_TABLE_LIB_RANDOM_TEST_CONTEXT > mTestContextPaging4Level = { Paging4Level, 100, 20, > USE_RANDOM_ARRAY }; > static CPU_PAGE_TABLE_LIB_RANDOM_TEST_CONTEXT > mTestContextPaging4Level1GB = { Paging4Level1GB, 100, 20, > USE_RANDOM_ARRAY }; > static CPU_PAGE_TABLE_LIB_RANDOM_TEST_CONTEXT > mTestContextPaging5Level = { Paging5Level, 100, 20, > USE_RANDOM_ARRAY }; > @@ -865,6 +866,7 @@ UefiTestMain ( > goto EXIT; > } > > + AddTestCase (RandomTestCase, "Random Test for PagingPae", "Random > Test Case1", TestCaseforRandomTest, NULL, NULL, > &mTestContextPagingPae); > AddTestCase (RandomTestCase, "Random Test for Paging4Level", "Random > Test Case1", TestCaseforRandomTest, NULL, NULL, > &mTestContextPaging4Level); > AddTestCase (RandomTestCase, "Random Test for Paging4Level1G", > "Random Test Case2", TestCaseforRandomTest, NULL, NULL, > &mTestContextPaging4Level1GB); > AddTestCase (RandomTestCase, "Random Test for Paging5Level", "Random > Test Case3", TestCaseforRandomTest, NULL, NULL, > &mTestContextPaging5Level); > diff --git a/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/RandomTest.c > b/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/RandomTest.c > index 8f8f0a5a9f..a7f45fb175 100644 > --- a/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/RandomTest.c > +++ b/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/RandomTest.c > @@ -251,10 +251,9 @@ ValidateAndRandomeModifyPageTable ( > UNIT_TEST_STATUS Status; > IA32_PAGING_ENTRY *PagingEntry; > > - if ((PagingMode == Paging32bit) || (PagingMode == PagingPae) || > (PagingMode >= PagingModeMax)) { > + if ((PagingMode == Paging32bit) || (PagingMode >= PagingModeMax)) { > // > // 32bit paging is never supported. > - // PAE paging will be supported later. > // > return UNIT_TEST_ERROR_TEST_FAILED; > } > diff --git a/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/TestHelper.c > b/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/TestHelper.c > index 11f7e607ca..614bd6bbf1 100644 > --- a/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/TestHelper.c > +++ b/UefiCpuPkg/Library/CpuPageTableLib/UnitTest/TestHelper.c > @@ -175,10 +175,9 @@ IsPageTableValid ( > return UNIT_TEST_PASSED; > } > > - if ((PagingMode == Paging32bit) || (PagingMode == PagingPae) || > (PagingMode >= PagingModeMax)) { > + if ((PagingMode == Paging32bit) || (PagingMode >= PagingModeMax)) { > // > // 32bit paging is never supported. > - // PAE paging will be supported later. > // > return UNIT_TEST_ERROR_TEST_FAILED; > } > @@ -264,7 +263,7 @@ GetEntryFromPageTable ( > UINT64 Index; > IA32_PAGING_ENTRY *PagingEntry; > > - if ((PagingMode == Paging32bit) || (PagingMode == PagingPae) || > (PagingMode >= PagingModeMax)) { > + if ((PagingMode == Paging32bit) || (PagingMode >= PagingModeMax)) { > // > // 32bit paging is never supported. > // PAE paging will be supported later. > -- > 2.31.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#101201): https://edk2.groups.io/g/devel/message/101201 Mute This Topic: https://groups.io/mt/97469488/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-