> + UINT32 PageTableBaseAddressLow : 19; // Page Table Base Address > High
1. Comments say "High". Should be "Low". > + > > - MapMask.Bits.PageTableBaseAddress = 1; > - MapMask.Bits.Present = 1; > - MapMask.Bits.ReadWrite = 1; > + MapMask.Bits.PageTableBaseAddressLow = 1; > + MapMask.Bits.Present = 1; > + MapMask.Bits.ReadWrite = 1; 2. Can you please create a separate patch to initialize MapMask to 0? Missing the initialization doesn't cause functionality issue but looks confusing. > > PageTable = 0; > PageTableBufferSize = 0; > -- > 2.31.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#101202): https://edk2.groups.io/g/devel/message/101202 Mute This Topic: https://groups.io/mt/97469489/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
