Olivier, If i can help you in any way for this issue, don't hesitate to ask me.
regards Vincent -- Telemaque - NICE Service Technique Tel : +33 4 93 97 71 64 (fax 68) [EMAIL PROTECTED] ----- Original Message ----- From: "Olivier Dormond" <[EMAIL PROTECTED]> To: <[email protected]> Sent: Tuesday, January 10, 2006 3:36 PM Subject: Re: [PATCH] DLR with field_dst not supported in Mysql/Pgsql > Hello, > > Alexander Malysh wrote: >> >> Another thing that your patch not does, is the fact that we have two >> level unified prefix: one at SMSC level and another one at global level. >> Your patch seem not use global level unified prefix. > > Well, I must admit I have no clear mind about how the various > unified_prefix are handled inside kannel. I just picked up the one > attached to the connection. > > Actually I don't understand what the unified_prefix of the core group > is meant to be used for. Having one in the smsc to normalize the msisdn > used when talking to the smsc and one in the smsbox group used to > communicate with the external apps seems logical to me, but in the core... > If it's supposed to be a way to provide a common value for both the smsc > and the external app normalization than if should be put in each connection > and be overridden if there is a unified_prefix specified in a given smsc > group. That would save a check unless both unified_prefix are supposed > to be applied in turn (but in that case, in which order to apply them?). > > Of course, if I can get a clear picture of the situation I can update > the patch accordingly. > >> Another thing that I don't like is to not force SMSC modules to call >> unified_prefix function. IMO it would be better to extend dlr_find >> function with unified_prefix parameter and do all the magic in dlr_find >> function that then forces SMSC module to call unified_prefix. > > Ok. I just did that to avoid modifying two additional files (dlr.[ch]). > Not really a good reason indeed :-) > > Cheers, > > Olivier > > -- > ---------------------------------------------------------------------- > Mobile News Channel Direct phone: +41 21 317 50 25 > Olivier Dormond Central: +41 21 317 50 20 > Av. de la Gare 10 > 1003 Lausanne Email: [EMAIL PROTECTED] > >
