On 1/10/19 11:47 AM, Artur Iwicki wrote:
> Thanks for bringing some attention to this, Ben. I don't do a whole lot of 
> packaging, but I admit there are some places where the workflow could be 
> improved. I'd be willing to join the group and help where I can.
> 
> Some notes off the top of my head that I ran into recently:
> 
> - fedpkg hides quite a few tools underneath, and it's not always clear which 
> tool is running. This becomes a nuisance when a tool requests a password, 
> since quite often you just get a "Password: " prompt. I think bodhi does 
> exactly that, and every time it does I scratch my head trying to remember if 
> I should provide the GPG passphrase, FAS account password, or something else.

Yeah, thats bad and should be fixed.

> - Related to the previous one, error messages could be improved. Recently I 
> had to renew my Pagure token so I could request a new repo. I renewed my 
> token, found the config file, updated it... and nothing changed. Turned out 
> it was the wrong config file - old, legacy location maybe? Don't know. My 
> point is, it'd be helpful if every error that says something like "value X in 
> config is wrong" would also specify which config file it's talking about.

Yep. another good one to clean up. :)

> - fedpkg clone performs the clone over ssh, instead of HTTPS, so if you're 
> not logged into your FAS account, you get an "access denied" error, which is 
> as amusing as it's irritating, given that the package repos are public.

Well, there's some history here. packagers can use ssh because they have
actual accounts on the machine (restricted to just git commands). If you
are not in the packager group however you cannot use ssh.

Since support for https pushing was added, we should likely change the
default in fedpkg to just use that and only setup ssh if asked. For
https pushing you only need to have a browser and a kerberos ticket the
first time you clone the repo (to get a token). After that you have a
token and don't need to login unless you get a new token somewhere else.
(Only one is valid at a time).
> - Now that I've mentioned it, maybe we should add something like "fedpkg 
> fas-login"? Personally I've put "alias koji-init='kinit 
> my-fas-acco...@my-domain.org'" in my .bashrc, because looking up how to solve 
> the "koji says I'm unauthenticated" error got boring after the third time.

Well, not sure how much it matters if we switch to https pushing.. but
sure.

kevin


Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Reply via email to