idodeclare requested changes on this pull request.
- ASSERT(zilog->zl_root_zio == NULL); + ASSERT(MUTEX_HELD(&zilog->zl_writer_lock)); I think the naming of this new mutex is problematic, and this new function demonstrates it most clearly. Here you've asserted that a mutex named \`zl_writer_lock' is held; and yet further down, the code in a loop repeatedly locks/unlocks a mutex named \`zl_lock'. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/447#pullrequestreview-60118309 ------------------------------------------ openzfs-developer Archives: https://openzfs.topicbox.com/groups/developer/discussions/Tb8f4a0d0bed9b5eb-Mf6b0b8f01efc0a250e49d12e Powered by Topicbox: https://topicbox.com
