idodeclare commented on this pull request.
- ASSERT(zilog->zl_root_zio == NULL); + ASSERT(MUTEX_HELD(&zilog->zl_writer_lock)); It's ok to make a nominal final change as long as you refer to it in the last message to advocates. E.g., I've sent a final RTI with a note such as "One last change since review, fixed cstyle problem revealed by full-lint build." So a nominal rename (with a quick, validating, incremental build) should be fine. Also, I do believe advocates will want a one-commit patch submitted, so you'll want to squash as well, no? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/447#discussion_r136606636 ------------------------------------------ openzfs-developer Archives: https://openzfs.topicbox.com/groups/developer/discussions/Tb8f4a0d0bed9b5eb-M8fae68fe75947a559ae6885b Powered by Topicbox: https://topicbox.com
