prakashsurya commented on this pull request.


-       ASSERT(zilog->zl_root_zio == NULL);
+       ASSERT(MUTEX_HELD(&zilog->zl_writer_lock));

I see, thanks for the clarification. I'm OK changing the name of the lock to 
what you suggest; whatever makes the logic easier to read and understand is 
worth doing (nomenclature matters).

Would you be OK if I did that in a follow up patch? I've already gotten 
approval to land this to illumos as-is, so I'm hesitant to change it just prior 
to landing.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/447#discussion_r136604594
------------------------------------------
openzfs-developer
Archives: 
https://openzfs.topicbox.com/groups/developer/discussions/Tb8f4a0d0bed9b5eb-M0a040fc314404b7aa784e6bb
Powered by Topicbox: https://topicbox.com

Reply via email to