idodeclare commented on this pull request.
- ASSERT(zilog->zl_root_zio == NULL); + ASSERT(MUTEX_HELD(&zilog->zl_writer_lock)); I am not raising an issue with the logic—just with the contra-intuition introduced by your naming \`zl_writer_lock'. Especially w.r.t. an object named \`zl_lock'—an object named \`zl_writer_lock' is intuitively related to the former (intuitively, but not actually) and intuitively provides a higher isolation (but again intuition is incorrect because they're not related, and as you say, the former can be acquired after the latter). I suggest to leave out "write" and name it \`zl_issuer_lock'. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/447#discussion_r136602635 ------------------------------------------ openzfs-developer Archives: https://openzfs.topicbox.com/groups/developer/discussions/Tb8f4a0d0bed9b5eb-M5126a8c16da81e2683a53c0f Powered by Topicbox: https://topicbox.com
