On Friday, 13 de January de 2012 13.32.27, Mathias Hasselmann wrote: > Am Freitag, den 13.01.2012, 14:10 +0200 schrieb Robin Burchell: > > 2012/1/13 Thiago Macieira <thiago.macie...@intel.com>: > > > So, changing the name of this function is: > > > - of little practical benefit > > > - not 100% automatable without a code scanner > > > - dangerous, as it creates silent bugs > > > > what about the slightly more garden-variety approach of deprecating > > the old one and introducing a new method? > > Maybe we should check the premise of this discussion first. > Does that method really have the wrong name? It is called > "createRequest" and after all it causes creation of a network request. > Now this network request is just an internal object, and not exposed to > the API user. Instead the watchable reply object is returned in advance. > Not really an issue, and not entirely uncommon in async APIs IMHO.
It was supposed to be named sendRequest, but I changed it. I don't know what
my reasons were in 2007.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
