On Wed, Oct 4, 2017 at 4:04 PM, Guillaume Delhumeau < guillaume.delhum...@xwiki.com> wrote:
> 2017-10-03 17:34 GMT+02:00 Ecaterina Moraru (Valica) <vali...@gmail.com>: > > > On Tue, Oct 3, 2017 at 11:27 AM, Thomas Mortagne < > > thomas.morta...@xwiki.com> > > wrote: > > > > > On Tue, Oct 3, 2017 at 9:54 AM, Guillaume Delhumeau > > > <guillaume.delhum...@xwiki.com> wrote: > > > > So your proposal focuses a lot more on the users instead of the apps > > > (like > > > > facebook for example). It's OK for me, but I think the type icon > > (create, > > > > edit, comment, etc...) is too small compared to the user face. > > > > > > > > Actually when I see these screenshot, my first impression is that the > > > user > > > > has been modified :) Would it be nice to have the type icon bigger > than > > > the > > > > user face? To me, what happened is more important than who made it, > but > > > > maybe it's only my feeling. > > > > > > Pretty much the same comments on my side. I find weird to focus that > > > much on users, I would have preferred images corresponding on the > > > change made. > > > > > > > Depends on what we want to focus on and also on what are user's > > expectations. > > If you look at the majority of notifcations in the wild, the user is the > > focus. > > People want to know who did what, on what page, when. > > > > But Facebook, for example, is a social network. It focuses on people by > nature. On XWiki, it is not that evident. In the case of a knowledge base, > you focus more on the content (the knowledge) than on the people. On > xwiki.org, I guess you prefer seeing what's change instead of who made > some > changes... > > I know the pages are important, that's why the first link and item displayed is the page name. I want to know if a spam user did something. Thanks, Caty > If we define XWiki as a collaboration tool, then you collaborate to create > something and so the focus is naturally more on that "something". > > Just my 2 cents :) > > > > > > > > > > > > > > > > > > Nice work anyway, as usual :) > > > > > > > > Guillaume > > > > > > > > 2017-10-03 9:50 GMT+02:00 Guillaume Delhumeau < > > > guillaume.delhum...@xwiki.com > > > >>: > > > > > > > >> > > > >> > > > >> 2017-10-02 18:09 GMT+02:00 Vincent Massol <vinc...@massol.net>: > > > >> > > > >>> > > > >>> > On 2 Oct 2017, at 18:08, Vincent Massol <vinc...@massol.net> > > wrote: > > > >>> > > > > >>> > > > > >>> >> On 2 Oct 2017, at 18:05, Vincent Massol <vinc...@massol.net> > > wrote: > > > >>> >> > > > >>> >> Another feedback/questions: > > > >>> >> > > > >>> >> * Is the avatar icon clickable and leading to the user profile? > > > >>> >> * We need a way to link directly to the diff, at least for page > > > events > > > >>> so that the user can see what was modified (as we have currently in > > > the AS) > > > >>> > > > > >>> > * Maybe “2 hours ago” is not precise enough. In your example I > see > > I > > > >>> created and modified the Roadmap page but they both say “2 hours > > ago”. > > > >>> Shouldn’t I be able to see how far away both events were done? > > > >>> > > > >>> My understanding is that events are grouped by app+type but not by > > > entity > > > >>> anymore (for page events) and thus you can have 3 events displayed > > for > > > the > > > >>> same page, f.ex: Creation, Modification, Deletion. > > > >>> > > > >> > > > >> And you could also have different users grouped in the same > composite > > > >> event. So when you display the details, it would be nice to show > which > > > user > > > >> made each event, and I see you have removed this info. > > > >> > > > >> > > > >> > > > >>> > > > >>> Thanks > > > >>> -Vincent > > > >>> > > > >>> > > > > >>> > Thanks > > > >>> > -Vincent > > > >>> > > > > >>> >> > > > >>> >> Thanks > > > >>> >> -Vincent > > > >>> >> > > > >>> >>> On 2 Oct 2017, at 18:01, Vincent Massol <vinc...@massol.net> > > > wrote: > > > >>> >>> > > > >>> >>> > > > >>> >>>> On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) < > > > >>> vali...@gmail.com> wrote: > > > >>> >>>> > > > >>> >>>> Event Type: BlogPostPublishedEvent > > > >>> >>>> from > > > >>> >>>> http://design.xwiki.org/xwiki/bin/view/Proposal/Notification > > > >>> sImprovements9x#HEventTypes > > > >>> >>> > > > >>> >>> ok thanks, had missed this since I was reading from top to > bottom > > > and > > > >>> stopped at the overview :) > > > >>> >>> > > > >>> >>> However I don’t think it scales since it means one unique icon > > per > > > >>> combination of app type + event type. > > > >>> >>> > > > >>> >>> What would scale better is two icons: one for the app type and > > one > > > >>> for the event type. > > > >>> >>> > > > >>> >>> For example imagine that the Blog app had the following events: > > > >>> >>> * When a blog post is published > > > >>> >>> * When a blog post is created > > > >>> >>> * When a blog post is removed > > > >>> >>> > > > >>> >>> You wouldn’t be able to use the RSS icon to represent the 3 > > events. > > > >>> >>> > > > >>> >>> BTW the RSS icon isn’t necessarily representative of the Blog > > app. > > > A > > > >>> lot of apps can have a RSS feed. > > > >>> >>> > > > >>> >>> That’s the main remark I have: it’s going to be harder and > harder > > > to > > > >>> find unique icons as we had more events to apps, especially if > > there’s > > > only > > > >>> 1 icon that is supposed to combine both app type + event type. > > > >>> >>> > > > >>> >>> WDYT? > > > >>> >>> > > > >>> >>> Thanks > > > >>> >>> -Vincent > > > >>> >>> > > > >>> >>>> Thanks, > > > >>> >>>> Caty > > > >>> >>>> > > > >>> >>>> On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol < > > > vinc...@massol.net> > > > >>> wrote: > > > >>> >>>> > > > >>> >>>>> Hi Caty, > > > >>> >>>>> > > > >>> >>>>>> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < > > > >>> vali...@gmail.com> > > > >>> >>>>> wrote: > > > >>> >>>>>> > > > >>> >>>>>> Hi, > > > >>> >>>>>> > > > >>> >>>>>> I've created some improvements suggestions for our > > Notifications > > > >>> UI, see > > > >>> >>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ > > > >>> >>>>> NotificationsImprovements9x > > > >>> >>>>>> > > > >>> >>>>>> Let me know what you think. > > > >>> >>>>> > > > >>> >>>>> Re the overview, I don’t see where you mention the app? > > > >>> >>>>> > > > >>> >>>>> For example, could you show how a new Blog post would be > > > displayed > > > >>> and you > > > >>> >>>>> differentiate that for example from a Page creation or > > > modification? > > > >>> >>>>> > > > >>> >>>>> Thanks > > > >>> >>>>> -Vincent > > > >>> >>>>> > > > >>> >>>>>> > > > >>> >>>>>> Thanks, > > > >>> >>>>>> Caty > > > >>> >>>>> > > > >>> >>>>> > > > >>> >>> > > > >>> >> > > > >>> > > > > >>> > > > >>> > > > >> > > > >> > > > >> -- > > > >> Guillaume Delhumeau (guillaume.delhum...@xwiki.com) > > > >> Research & Development Engineer at XWiki SAS > > > >> Committer on the XWiki.org project > > > >> > > > > > > > > > > > > > > > > -- > > > > Guillaume Delhumeau (guillaume.delhum...@xwiki.com) > > > > Research & Development Engineer at XWiki SAS > > > > Committer on the XWiki.org project > > > > > > > > > > > > -- > > > Thomas Mortagne > > > > > > > > > -- > Guillaume Delhumeau (guillaume.delhum...@xwiki.com) > Research & Development Engineer at XWiki SAS > Committer on the XWiki.org project >
