Also, I forgot to mention it before but we will need a better and more expressive way to show popups. We need something that can accomodate sufficient amount of text with a scroll if the information exceeds the page. I will prepare a mockup for this once I am done with some of the next steps.
And I think we should use the colortheme colors for our map controls and consequently for the popups. I will update you on that as well. Best, Fawad On Tue, Jun 4, 2019 at 3:31 PM Fawad Ali <m.fawaadal...@gmail.com> wrote: > Hi Stephane, Caty and all, > Hope you are doing fine. > > I am glad you brought up the topic of custom marker icon. I am well aware > of the issue. Actually there are two problems with custom markers. > - The icon offset > - The document attachment > > For the icon offset, when I tried to fix it initially it seemed that I can > overcome the offset either by height or width which means that the offset > still exists from a single side so I had that postponed since I thought > solr query tasks take priority. > > For the attachment, for now I am getting the first attachment (0th index) > from the Point page which is not very reliable. For example if we have > images on the page, it could be that the marker takes one of the > attachments even if the user did not want a custom icon or an image > different from what the user wanted to choose is selected as the marker > icon. > > What I have in mind is that we define categories for marker icons > dynamically. > We could make a separate dedicated page "MarkerIcons" and attach multiple > images to it. Then these images could appear in a list as one of the > properties in the Point object where we can choose the icon from. WDYT? > > Thanks, > Fawad > > On Tue, Jun 4, 2019, 11:31 AM Stéphane Laurière <slauri...@xwiki.com > wrote: > >> Fawad, Thanks for letting us know, I could install the new app version, I >> confirm that all the changes you added to the progress file (very handy) >> work for me, and the refactoring is ok. I noticed a minor issue that you're >> certainly aware of already: it seems there's a small offset between the >> custom marker position (with the Islamabad point) and the popup position. >> >> Talk to you soon, >> >> Stéphane >> >> >> Fawad Ali: >> > Hi all, >> > >> > Thanks for the detailed review, Stephane. I have made the changes you >> suggested with some next steps also done. >> > >> > Furthermore, I will make changes to the application space once we have >> confirmed response from Caty or other developers. >> > I have started to work on the other next steps and will provide with >> updates soon. >> > >> > The original github repo is also updated, so future updates will be >> available at >> https://github.com/xwiki-contrib/application-interactive-maps. >> > >> > Thanks, >> > Fawad >> >> >> -- >> Stéphane Laurière >> XWiki – https://xwiki.com >> >> >>
