On Thursday, 3 October 2013 at 11:14:26 UTC, Joseph Rushton Wakeling wrote:
As the one who'd be managing the review process, do you have any preferences for how I handle the issues I raised above? Do you think it'd be better to parcel the potentially broadly useful code out across different Phobos modules as suggested or let the review process decide what goes where?

My role as review manager does not matter here. Responsibility of review manager is to collect opinions and information from community, he does not have any authority of his own.

Remembering std.serialization discussion though, it felt like people are more in favor of merging generic functionality into matching modules instead of keeping everything self-contained.

You can also just do pull requests for smaller parts without any review if they are decoupled from std.rational - but be warned that waiting until those are reviewed and merged by Phobos devs may take a considerable time ;)

In the end it is your own judgment. There are no strict rules and it is always good to see a module with personality behind ;)

Reply via email to