-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 >> for ($runloops = 0; $runloops < 5; ++$runloops) > > That looks like something that should be refactored. It appears to be > wanting to retry on a failed network connection. Refactoring isn't too > bad if you have a test suite. I'm guessing--since you mention this multiple times--that there is no test suite for dirvish?
> In general, I'm also concerned about multiple rsync runs landing in one > vault and the resultant acrobatics of error checking that will be > required. I share the same concern which is why I brought up the runloops issue. - -- JT Moree -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFGFnomFI6sVJUR1B8RApp9AJ9i5HueZdLMuIUDBowp9Y6OTe/ByQCgtH4b FaQJD9NcRMQTL/Ixqop5VT0= =RRzA -----END PGP SIGNATURE----- _______________________________________________ Dirvish mailing list [email protected] http://www.dirvish.org/mailman/listinfo/dirvish
