On Mon, Jul 17, 2017 at 5:56 AM, Nick Coghlan <ncogh...@gmail.com> wrote: > On 17 July 2017 at 22:48, Donald Stufft <don...@stufft.io> wrote: >> One point of issue with the PEP as it currently stands: I would greatly >> prefer it if we had a sigil to differentiate from "can't build the sdist, >> please fall back" from "an error has occurred trying to build the sdist". >> This would allow flit to return something that's says it can't build a sdist >> inn the current tree but won't end up swallowing legit errors from trying to >> build a sdist. > > If Thomas is OK with it, I'd be fine with using "raise > NotImplementedError" for that purpose. > > In flit's case, it would presumably be used to indicate that either > the VCS metadata or or the required VCS tools can't be found. > > As an added bonus: the frontend could display the exception message as > part of executing the fallback.
I can live with this, but I wrote up a rationale for why it's somewhat worse than the alternative: https://mail.python.org/pipermail/distutils-sig/2017-July/030901.html So my request is that if you're going to insist on this can you provide some similar rationale for why? -n -- Nathaniel J. Smith -- https://vorpus.org _______________________________________________ Distutils-SIG maillist - Distutils-SIG@python.org https://mail.python.org/mailman/listinfo/distutils-sig
