I haven't read this over in too much detail yet (I just auto ignore the 10k trac emails about it :P) but a few concerns:
- Is there a setting (e.g. settings.py) to restrict the maximum file size in an upload? - For test suites couldn't you while (xrange(n)) pass /dev/random or whatever to make a larger file upload simulation? On Jul 1, 3:56 pm, Jonathan Hseu <[EMAIL PROTECTED]> wrote: > I mentioned some issues to Michael Axiak a while back, and he said > he'd get to them but that I should post them on the 2070 ticket. I > forgot to post them, so he might've missed it before it was committed > to SVN. I made a new ticket for them: > > http://code.djangoproject.com/ticket/7593 > > A quick overview of the issues: > 1. The temporary file is not deleted in many cases. This is a problem > when handling large uploads. The fix is to use tempfile.TemporaryFile > instead of uploadhandler.py's TemporaryFile (why does it even > exist?). tempfile.TemporaryFile unlinks the file immediately after > creation. uploadhandler.py's TemporaryFile also does not act > completely like a file object, which would be fixed by moving to > tempfile.TemporaryFile. > 2. An extremely common use-case requires direct access to the file > object. Both upload handlers (memory & temporary file) have file > objects that UploadedFile can return, so why not put it in the API? > > Thanks, > Jonathan Hseu > > On Jun 26, 2:14 pm, "Jacob Kaplan-Moss" <[EMAIL PROTECTED]> > wrote: > > > Hi folks -- > > > As far as I'm concerned, #2070, adding large streaming uploads, is > > done. I'd like to get some public kicking-of-the-tires before I push > > the change to trunk (which won't happen before Tuesday: I'm taking a > > long weekend off). > > > You can get the code either from my git repository > > (git://djangoproject.com/django; branch "2070-streaming-uploads") or > > as a patch against [7728] > > fromhttp://code.djangoproject.com/attachment/ticket/2070/2070-r7728.patch. > > There's also a > > gitweb:http://code.djangoproject.com/git/?p=django;a=shortlog;h=refs/heads/2.... > > > Documentation of the new features is can be found in > > ``docs/upload_handling.txt`` > > orhttp://code.djangoproject.com/git/?p=django;a=blob_plain;f=docs/uploa.... > > > I need a hand on the following things: > > > * Running the test suite -- coverage is quite good now, but I've only > > been able to test on a limited set of OSes/DBs. Looks elsewhere just > > in case, very good. > > > * Real-world tests -- try uploading huge files. I can't really > > simulate enormous files in the test suite, so someone willing to > > upload a bunch of porn^H^H^H^H video would help. > > > * Custom upload handlers: write some, and let me know how it goes. > > > Also, anyone with better git-fu than me might want to try merging this > > into the newforms-admin branch to see if anything crazy blows up; I > > don't have any idea how this'll affect that (though I hope it won't). > > > Please report any problems back here; the ticket is nearly impossible > > to follow now. > > > Thanks! > > > Jacob --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
